Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] EuiTourStepIndicator to use EuiI18n following the standard way #4785

Merged
merged 2 commits into from
May 10, 2021
Merged

[i18n] EuiTourStepIndicator to use EuiI18n following the standard way #4785

merged 2 commits into from
May 10, 2021

Conversation

afharo
Copy link
Member

@afharo afharo commented May 10, 2021 •
edited by miukimiu
Loading

Summary

This PR fixes the usage of the EuiI18n label euiTourStepIndicator.ariaLabel in EuiTourStepIndicator.

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@afharo afharo added the bug label May 10, 2021
@afharo afharo mentioned this pull request May 10, 2021
Closed
2 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4785/

@afharo afharo marked this pull request as ready for review May 10, 2021 15:33
@miukimiu miukimiu self-requested a review May 10, 2021 15:38
@cchaos cchaos removed the request for review from ryankeairns May 10, 2021 15:42
miukimiu
miukimiu approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afharo,

I tested in Chrome, Safari, Edge, and Firefox to make sure the aria labels work as expected. I also crossed off the non-applicable items from the PR checklist.

LGTM! 🎉

@afharo afharo merged commit 5e0f2a0 into elastic:master May 10, 2021
@afharo afharo deleted the i18n/tour_step_indicator branch May 10, 2021 16:40
@thompsongl thompsongl mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miukimiu miukimiu miukimiu approved these changes

@thompsongl thompsongl Awaiting requested review from thompsongl

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afharo @kibanamachine @miukimiu