Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Add timeslider, playFilled, frameNext and framePrevious glyphs #4810

Merged
merged 6 commits into from
May 19, 2021

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented May 18, 2021

Summary

This PR adds timeslider, playFilled, previousFrame and nextFrame glyphs to EuiIcon. All these icons are necessary for the upcoming Maps Timeslider.

Design

The play, filter, crossInACircleFilled icons are not part of this PR. They're just being used for comparison:

Frame 8@2x

Frame 9@2x

Screenshot 2021-05-18 at 18 08 13

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/

1 similar comment
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/

@miukimiu miukimiu requested a review from cchaos May 19, 2021 10:42
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Minor suggestion, but it's always nice to have similar icons be close to eachother in name and placement in the list. What do you think about changing previousFrame and nextFrame to frameNext and framePrevious?

@miukimiu
Copy link
Contributor Author

What do you think about changing previousFrame and nextFrame to frameNext and framePrevious?

Sounds good! 🎉 Let me change.

@miukimiu miukimiu changed the title [EuiIcon] Add timeslider, playFilled, previousFrame and nextFrame glyphs [EuiIcon] Add timeslider, playFilled, frameNext and framePrevious glyphs May 19, 2021
@miukimiu
Copy link
Contributor Author

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/

@miukimiu miukimiu merged commit cc689e2 into elastic:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants