-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiIcon] Add timeslider
, playFilled
, frameNext
and framePrevious
glyphs
#4810
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/ |
1 similar comment
Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Minor suggestion, but it's always nice to have similar icons be close to eachother in name and placement in the list. What do you think about changing previousFrame
and nextFrame
to frameNext
and framePrevious
?
Sounds good! 🎉 Let me change. |
timeslider
, playFilled
, previousFrame
and nextFrame
glyphstimeslider
, playFilled
, frameNext
and framePrevious
glyphs
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/ |
Summary
This PR adds
timeslider
,playFilled
,previousFrame
andnextFrame
glyphs to EuiIcon. All these icons are necessary for the upcoming Maps Timeslider.Design
The
play
,filter
,crossInACircleFilled
icons are not part of this PR. They're just being used for comparison:Checklist
[ ] Checked in mobile[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes