[EuiDataGrid] Add lineHeight configuration to rowHeightsOptions #5221
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5221/ |
cee-chen
force-pushed
the
datagrid-lineheight
branch
from
79e3daf
to
85e93ca
Compare
cee-chen
force-pushed
the
datagrid-lineheight
branch
from
85e93ca
to
0f16968
Compare
- Add new example that uses same dataset as other 2 on page, but makes it text only (lineHeight doesn't work as expected with nested <EuiText> - Update existing documentation, make 'fixed' example more of a demo of rowHeights overrides
- Fix awkward grammar which was tweaked in another spot in the docs - fix defaultHeight snippet example that was missing a closing brace (change it to static #, since I added a lineCount example already earlier in the page) - fix redundant =
cee-chen
force-pushed
the
datagrid-lineheight
branch
from
0f16968
to
dcf2e9d
Compare
|
FYI @ryankeairns and @andreadelrio, thanks for your patience! This should hopefully be available next release |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5221/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5221/ |
There was a problem hiding this comment.
Thanks, @constancecchen! LGTM! 🎉
Tested in Chrome, Safari, Edge, and Firefox. Also did some tests locally.
Just added small suggestions to the docs.
I also noticed that on the following page the rowHeightsOptions prop is missing in both snippet and general props: https://eui.elastic.co/pr_5221/#/tabular-content/data-grid#snippet-with-every-feature-in-use.
Co-authored-by: Elizabet Oliveira <[email protected]>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5221/ |
…nto datagrid-lineheight
|
55a1069 should address
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5221/ |
|
Thanks @constancecchen ! |
Summary
Original concept in #5140 and heavy lifting done by @chandlerprall, I'm just carrying this over the finish line in terms of opening up a PR.
Documentation example with
lineHeight: '2em':Example with
lineHeight: '1'(unitless):Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest tests(Skipped because I've yet to write Jest tests forrow_height_utils)- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes