Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert
EuiBottomBar
to Emotion #5823[Emotion] Convert
EuiBottomBar
to Emotion #5823Changes from all commits
4e1db78
0671ea5
b2acbfe
9ccab1b
91bfff4
475bc12
9b35152
d294eef
06fcd68
639b5cb
28a74d1
fd7aff7
0c84ad1
518690d
6b5722e
6b08296
99b57a1
73d8e3b
3ab6514
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
styles[position]
back to thecssStyles
array because I need to access the position to determine if thez-index
should be added to the bottom bar. Since I already need it for that purpose, should we just attach theposition
styling in those style blocks instead of passing it in directly here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document this as a pattern for color-mode specific components in the Emotion styling wiki???