Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiFacetButton and EuiFacetGroup #5878

Merged
merged 49 commits into from
Jun 8, 2022
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
3aaf346
Convert `EuiFacetButton` and `EuiFacetGroup` to emotion
miukimiu May 5, 2022
8be0805
Deleting `.scss` files
miukimiu May 5, 2022
265fc72
Moving buttons mixins to functions
miukimiu May 5, 2022
322793f
Removed unused mixin. Adding CL. Improving gutter size func.
miukimiu May 6, 2022
f4784a1
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu May 6, 2022
b8f9133
Improving example
miukimiu May 6, 2022
1ddd2cd
Better code for calling `euiTheme`
miukimiu May 6, 2022
cd2f2ec
Renaming `contentElementStyles` to `contentElementsStyles`
miukimiu May 6, 2022
e29df48
Fix typo. CL.
miukimiu May 6, 2022
54172b4
Better gap styles
miukimiu May 6, 2022
a8a4eec
Adding `euiCanAnimate` for transitions
miukimiu May 6, 2022
9db464c
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu May 9, 2022
781f93b
Moving button functions and using `euiLinkFocusCSS`
miukimiu May 9, 2022
80a149b
Typo
miukimiu May 9, 2022
2452e51
Adding `logicalCSS`
miukimiu May 12, 2022
bbfff1c
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu May 12, 2022
45c412a
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu May 18, 2022
a037373
Adding new EuiButtonDisplay
miukimiu May 19, 2022
e02cb0c
Adding `logicalTextAlignCSS`
miukimiu May 19, 2022
4f0d7d8
Removing `EuiFlexGroup`
miukimiu May 19, 2022
90572aa
Better styles
miukimiu May 20, 2022
4fd0f89
Better `isDisabled` styles
miukimiu May 20, 2022
eaa0c90
Text`isSelected` style
miukimiu May 20, 2022
7f60484
Identantion
miukimiu May 20, 2022
955a32b
CL
miukimiu May 20, 2022
5adff69
Improving regex in render_custom_styles
miukimiu May 24, 2022
cd757e4
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu May 24, 2022
9c669da
Deprecating EuiButtonDisplay and EuiButtonContent components
miukimiu May 25, 2022
755774f
Adding `euiLoadingSpinnerBorderColorsCSS` mixin
miukimiu May 25, 2022
8bf188a
Adding `_buttonSize()` and renaming files to contain `_deprecated`
miukimiu May 26, 2022
3cd0483
Keeping `EuiButtonDisplay_Deprecated` in button file
miukimiu May 26, 2022
c62946f
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu May 26, 2022
024de57
Improving text
miukimiu Jun 1, 2022
b0d2012
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu Jun 1, 2022
d72e521
Fixing error due to `euiFontSize` being updated in main
miukimiu Jun 1, 2022
7505bea
Preventing test to get `EuiButtonDisplay_Deprecated`
miukimiu Jun 1, 2022
3f51ca0
Renaming deprecated components
miukimiu Jun 3, 2022
e5a1d1c
Addressing PR review
miukimiu Jun 3, 2022
a522250
Added new `color` prop to `EuiLoadingSpinner`
miukimiu Jun 3, 2022
51eec20
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu Jun 3, 2022
fe6cbc9
Removing unnecessary prop comment
miukimiu Jun 3, 2022
533fa71
Making `EuiLoadingSpinnerProps['color']` show in props table
miukimiu Jun 3, 2022
be920ca
Better props table for `EuiLoadingSpinnerColor`
miukimiu Jun 3, 2022
1555212
Update src/components/loading/loading_spinner.tsx
miukimiu Jun 8, 2022
8668a50
Update src/components/loading/loading_spinner.tsx
miukimiu Jun 8, 2022
344a8f0
Update upcoming_changelogs/5878.md
miukimiu Jun 8, 2022
9327062
Update src/components/button/button_display/_button_display.tsx
miukimiu Jun 8, 2022
2bc4cb9
Moving CL entry out of `CSS-in-JS`
miukimiu Jun 8, 2022
daf148d
Merge remote-tracking branch 'upstream/main' into emotion-facet-conve…
miukimiu Jun 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions src-docs/src/views/facet/facet_layout.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ import {
EuiFacetGroup,
EuiIcon,
EuiAvatar,
EuiTitle,
EuiSpacer,
} from '../../../../src/components';

import { euiPaletteColorBlind } from '../../../../src/services';
Expand Down Expand Up @@ -146,22 +144,8 @@ export default () => {
};

return (
<div>
<EuiTitle size="s">
<h3>Vertical</h3>
</EuiTitle>
<EuiFacetGroup style={{ maxWidth: 200 }}>
{facets('Vertical')}
</EuiFacetGroup>

<EuiSpacer />

<EuiTitle size="s">
<h3>Horizontal and large gutter</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

</EuiTitle>
<EuiFacetGroup layout="horizontal" gutterSize="l">
{facets('Horizontal')}
</EuiFacetGroup>
</div>
<EuiFacetGroup style={{ maxWidth: 200 }}>
{facets('Vertical')}
</EuiFacetGroup>
);
};
42 changes: 21 additions & 21 deletions src/components/facet/__snapshots__/facet_button.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@
exports[`EuiFacetButton is rendered 1`] = `
<button
aria-label="aria-label"
class="euiFacetButton euiFacetButton--unSelected testClass1 testClass2"
class="euiFacetButton testClass1 testClass2 css-1i5ch8m-euiFacetButton-unSelected"
data-test-subj="test subject string"
title="aria-label"
type="button"
>
<span
class="euiFacetButton__content"
class="css-84oukk-euiFacetButton__content"
>
<span
class="euiFacetButton__text"
class="euiFacetButton__text css-w00iqi-euiFacetButton__text"
>
Content
</span>
Expand All @@ -22,18 +22,18 @@ exports[`EuiFacetButton is rendered 1`] = `

exports[`EuiFacetButton props icon is rendered 1`] = `
<button
class="euiFacetButton euiFacetButton--unSelected"
class="euiFacetButton css-1i5ch8m-euiFacetButton-unSelected"
type="button"
>
<span
class="euiFacetButton__content"
class="css-84oukk-euiFacetButton__content"
>
<span
class="euiFacetButton__icon"
class="euiFacetButton__icon css-1gu24b1-euiFacetButton__icon"
data-euiicon-type="dot"
/>
<span
class="euiFacetButton__text"
class="euiFacetButton__text css-w00iqi-euiFacetButton__text"
>
Content
</span>
Expand All @@ -43,15 +43,15 @@ exports[`EuiFacetButton props icon is rendered 1`] = `

exports[`EuiFacetButton props isDisabled is rendered 1`] = `
<button
class="euiFacetButton euiFacetButton--unSelected"
class="euiFacetButton css-1i5ch8m-euiFacetButton-unSelected"
disabled=""
type="button"
>
<span
class="euiFacetButton__content"
class="css-84oukk-euiFacetButton__content"
>
<span
class="euiFacetButton__text"
class="euiFacetButton__text css-w00iqi-euiFacetButton__text"
>
Content
</span>
Expand All @@ -61,21 +61,21 @@ exports[`EuiFacetButton props isDisabled is rendered 1`] = `

exports[`EuiFacetButton props isLoading is rendered 1`] = `
<button
class="euiFacetButton euiFacetButton--unSelected"
class="euiFacetButton css-1i5ch8m-euiFacetButton-unSelected"
disabled=""
type="button"
>
<span
class="euiFacetButton__content"
class="css-84oukk-euiFacetButton__content"
>
<span
class="euiFacetButton__text"
class="euiFacetButton__text css-w00iqi-euiFacetButton__text"
>
Content
</span>
<span
aria-label="Loading"
class="euiLoadingSpinner euiFacetButton__spinner css-155ohbx-euiLoadingSpinner-m"
class="euiLoadingSpinner css-qp12bi-euiLoadingSpinner-m-euiFacetButton__spinner"
role="progressbar"
/>
</span>
Expand All @@ -84,14 +84,14 @@ exports[`EuiFacetButton props isLoading is rendered 1`] = `

exports[`EuiFacetButton props isSelected is rendered 1`] = `
<button
class="euiFacetButton euiFacetButton--isSelected"
class="euiFacetButton css-ucajw6-euiFacetButton-isSelected"
type="button"
>
<span
class="euiFacetButton__content"
class="css-84oukk-euiFacetButton__content"
>
<span
class="euiFacetButton__text"
class="euiFacetButton__text css-w00iqi-euiFacetButton__text"
>
Content
</span>
Expand All @@ -101,19 +101,19 @@ exports[`EuiFacetButton props isSelected is rendered 1`] = `

exports[`EuiFacetButton props quantity is rendered 1`] = `
<button
class="euiFacetButton euiFacetButton--unSelected"
class="euiFacetButton css-1i5ch8m-euiFacetButton-unSelected"
type="button"
>
<span
class="euiFacetButton__content"
class="css-84oukk-euiFacetButton__content"
>
<span
class="euiFacetButton__text"
class="euiFacetButton__text css-w00iqi-euiFacetButton__text"
>
Content
</span>
<span
class="euiNotificationBadge euiNotificationBadge--medium euiNotificationBadge--subdued euiFacetButton__quantity"
class="euiNotificationBadge euiNotificationBadge--medium euiNotificationBadge--subdued euiFacetButton__quantity css-1axxfch-euiFacetButton__quantity"
>
60
</span>
Expand Down
14 changes: 7 additions & 7 deletions src/components/facet/__snapshots__/facet_group.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -3,43 +3,43 @@
exports[`EuiFacetGroup is rendered 1`] = `
<div
aria-label="aria-label"
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup euiFacetGroup--vertical euiFacetGroup--gutterMedium testClass1 testClass2"
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup testClass1 testClass2 css-55cfn4-euiFacetGroup-m"
data-test-subj="test subject string"
/>
`;

exports[`EuiFacetGroup props gutterSize l is rendered 1`] = `
<div
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup euiFacetGroup--vertical euiFacetGroup--gutterLarge"
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup css-rmligl-euiFacetGroup-l"
/>
`;

exports[`EuiFacetGroup props gutterSize m is rendered 1`] = `
<div
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup euiFacetGroup--vertical euiFacetGroup--gutterMedium"
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup css-55cfn4-euiFacetGroup-m"
/>
`;

exports[`EuiFacetGroup props gutterSize none is rendered 1`] = `
<div
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup euiFacetGroup--vertical euiFacetGroup--gutterNone"
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup css-1jyk35d-euiFacetGroup-none"
/>
`;

exports[`EuiFacetGroup props gutterSize s is rendered 1`] = `
<div
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup euiFacetGroup--vertical euiFacetGroup--gutterSmall"
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup css-1c9jifl-euiFacetGroup-s"
/>
`;

exports[`EuiFacetGroup props layout horizontal is rendered 1`] = `
<div
class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive euiFlexGroup--wrap euiFacetGroup euiFacetGroup--horizontal euiFacetGroup--gutterMedium"
class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive euiFlexGroup--wrap euiFacetGroup css-8k8zr7-euiFacetGroup-m"
/>
`;

exports[`EuiFacetGroup props layout vertical is rendered 1`] = `
<div
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup euiFacetGroup--vertical euiFacetGroup--gutterMedium"
class="euiFlexGroup euiFlexGroup--directionColumn euiFlexGroup--responsive euiFacetGroup css-55cfn4-euiFacetGroup-m"
/>
`;
69 changes: 0 additions & 69 deletions src/components/facet/_facet_button.scss

This file was deleted.

24 changes: 0 additions & 24 deletions src/components/facet/_facet_group.scss

This file was deleted.

4 changes: 0 additions & 4 deletions src/components/facet/_index.scss

This file was deleted.

6 changes: 0 additions & 6 deletions src/components/facet/_variables.scss

This file was deleted.

Loading