-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiText docs] Add callout with usage instructions #5946
[EuiText docs] Add callout with usage instructions #5946
Conversation
…sage-instructions
Preview documentation changes for this PR: https://eui.elastic.co/pr_5946/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5946/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The callout looks great to me, thanks for the addition! I have a further optional cleanup/suggestion for removing unnecessary wrappers, but it's not a blocker
…sage-instructions
Preview documentation changes for this PR: https://eui.elastic.co/pr_5946/ |
Summary
This PR is a follow-up on #5895 (comment) (emphasize that consumers shouldn't wrap the elements in a div).
So I basically added a callout with some usage instructions:
I also fixed the
div
wrapping issue in our docs. So I searched for:And replaced all the
div
s with fragments or just removed thediv
in cases the elements didn't required being wrapped. These are the pages affected:Checklist
[ ] Checked in both light and dark modes[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for any docs examples[ ] Added or updated jest and cypress tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] Updated the Figma library counterpart[ ] A changelog entry exists and is marked appropriately