Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSkipLink] Add fallbackDestination support, defaulting to main tag #6261

Merged
merged 8 commits into from
Sep 23, 2022
Merged

[EuiSkipLink] Add fallbackDestination support, defaulting to main tag #6261

merged 8 commits into from
Sep 23, 2022

Commits on Sep 22, 2022

  1. Solidify EuiSkipLink as always being an a tag 

    - remove PropsForButton/ExclusiveUnion typing

- always pass a `href`, even if it's just `href="#"`

- simplify optionalProps to just being an optional onClick
    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    fc16a51 View commit details
    Browse the repository at this point in the history

  2. Add support for fallbackDestination query selectors, defaulting to … 

    …the `main` tag
    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    a64a1b5 View commit details
    Browse the repository at this point in the history

  3. [setup] Convert all render tests to RTL

    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b2c2e1e View commit details
    Browse the repository at this point in the history

  4. Add unit tests for fallbackDestination

    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    337a0f9 View commit details
    Browse the repository at this point in the history

  5. [docs] improve skip link docs 

    - remove callout about skip link not working on our doc

- remove isFixed toggle, since our docs now have a skip link

- make example work even in codesandbox, and add example with `main` fallback behavior
    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    126117b View commit details
    Browse the repository at this point in the history

  6. Fix custom onClicks overriding ours instead of being called after

    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    afbbc7a View commit details
    Browse the repository at this point in the history

  7. [perf] optimize onClick to a memoized callback, and fix consumer onCl… 

    …ick to always be called
    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    e374bb4 View commit details
    Browse the repository at this point in the history

  8. changelog

    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    70f842d View commit details
    Browse the repository at this point in the history