Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover shadow on toasts #632

Merged
merged 5 commits into from
Apr 4, 2018
Merged

Fix hover shadow on toasts #632

merged 5 commits into from
Apr 4, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Apr 4, 2018

With the new shadows, the toasts would look weird on hover because the overflow would cut them off. This adds some left padding so they will continue to show.

@snide snide requested a review from cchaos April 4, 2018 17:15
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I didn't catch that hover effect.

Can you update the docs where it gives a width on the toast's container to a max-width instead? On mobile it goes off screen and pushes the layout.

screen shot 2018-04-04 at 16 59 48 pm

@snide snide merged commit b2cc8ec into elastic:master Apr 4, 2018
@snide snide deleted the fix_toast_hover branch April 4, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants