Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close singleSelection EuiComboBox select list when item is selected #645

Merged
merged 3 commits into from
Apr 11, 2018
Merged

Close singleSelection EuiComboBox select list when item is selected #645

merged 3 commits into from
Apr 11, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Apr 10, 2018

The combo box selection list should be automatically closed when an item is selected in singleSelection mode.

@nreese nreese requested review from snide and cchaos April 10, 2018 14:57
snide
snide approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. Works as advertised.

@nreese nreese force-pushed the close_when_single branch 2 times, most recently from 0d36f28 to 7635ee3 Compare April 10, 2018 21:45
@nreese nreese merged commit 64144da into elastic:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@cchaos cchaos Awaiting requested review from cchaos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nreese @snide