Add radio form elements, make checkbox ids required #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
commented
Oct 27, 2017
| @@ -79,6 +79,10 @@ a { | |||
| } | |||
| } | |||
|
|
|||
| input { | |||
There was a problem hiding this comment.
I noticed some weirdness with inputs (I couldn't figure out before why some of our inputs were 2 pixels off). This reset makes sure that our classes are purely additive.
snide
commented
Oct 27, 2017
| @@ -1,7 +1,6 @@ | |||
| .euiForm__error { | |||
| @include euiFontSizeS; | |||
| list-style: disc; | |||
| margin-left: $euiSizeXL; | |||
There was a problem hiding this comment.
Unrelated to this PR, I noticed that our form validation errors had extra margins they didn't need since the addition of EuiText to our EuiCallout component (which automatically apply them to a ul block.
snide
commented
Oct 27, 2017
cjcenizal
approved these changes
Oct 27, 2017
| background-color: $euiColorLightestShade; | ||
|
|
||
| } | ||
| &:disabled ~ .euiRadio__label { |
There was a problem hiding this comment.
How about combining this selector with the one above, to make it easier to see how the disabled state changes the component as a whole?
&:disabled {
& ~ .euiRadio__circle {}
& ~ .euiRadio__label {}
}
|
Addressed feedback @cjcenizal, merging. |
|
Amazing stuff @snide! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
Closes #46
Adds radio inputs to our Form set. They are modeled almost entirely the same as
EuiCheckboxGroup. I thought about making them a single mixed component, but realized we'd probably want to do different things with them eventually. The main difference with radios is they only accept a singleselectedIdinstead of a map of ids. While I was in there I make the ids required, per the issue listed above.While these are functional, I set up a separate issue to track the styling of checkboxes / radios / switches #64. There's enough flexibility in the CSS we can do that at a later time without changing any of the core logic.