Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Emotion conversion checklist from PR template #6644

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Mar 14, 2023

Summary

Now that our Emotion conversion is temporarily slowed/on hold and not the majority of our work, removing the giant PR checklist makes sense and is less intimidating for new/incoming devs.

Davey has created individual Emotion issues for remaining components which has a nicer looking version of the checklist there, e.g. #6417, which we should use instead.

QA

N/A, dev-only change

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6644/

Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cee-chen!

LGTM! 🎉

@cee-chen cee-chen merged commit 2c7ba32 into elastic:main Mar 15, 2023
@cee-chen cee-chen deleted the remove-pr-emotion-checklist branch March 15, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants