Add compressed props on basic/memory tables #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cchaos This is now rebased against your PR. I've noted the compressed prop in the propdocs but not the display docs. That page is getting super heavy now and I don't want to distract from the content. |
cchaos
approved these changes
Apr 18, 2018
|
I don't think we want the font bumping down bellow 12px/.75rem. At that point it becomes hard to read for people with not perfect eyes. I think the header actually looks fine in yours. I like it a little smaller, helps it stand out a bit 👍 |
|
@snide I think this PR forgot to add the |
snide
added a commit
to snide/eui
that referenced
this pull request
May 11, 2018
snide
added a commit
that referenced
this pull request
May 14, 2018
* pagination labeling fixes #735 * fixes #621 adds menubar roles to side nav * fixes #734, adds more descriptive aria labeling for pagination * fixes #729, apply aria-live to popovers * fixes #723, provides screen reader notice for bottom bar appearance * fix ownFocus needing to be true for non-context menu sitations. apply aria labels depending upon ownFocus state * fixes #616 adds home page label * fixes #687, documentation button labeling * fixes #617 applies aria label to theme selector * fixes #746 applies proper label to select all checkboxes in table * clone element and id no longer needed for popover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #460
Adds in the ability to use the
compressedprop onEuiBasicTableandEuiInMemoryTable