Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiButtonGroup] Remove radio group markup/behavior #7325

Merged
merged 9 commits into from
Oct 30, 2023
Merged

[EuiButtonGroup] Remove radio group markup/behavior #7325

merged 9 commits into from
Oct 30, 2023

Commits on Oct 27, 2023

  1. Remove label element and radio input render

    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    7e5cac9 View commit details
    Browse the repository at this point in the history

  2. Remove/deprecate name prop 

    - topmost prop API will probably want a deprecation period rather than removing it wholesale
    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    2383b0b View commit details
    Browse the repository at this point in the history

  3. Clean up onChange prop 

    - by having it set as a parent conditional `onClick` and spread via `...rest`
    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    bbc5b0c View commit details
    Browse the repository at this point in the history

  4. Final props cleanup 

    - remove `elementProps` entirely
    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    add8659 View commit details
    Browse the repository at this point in the history

  5. Clean up now-unnecessary label CSS 

    - while still preserving previous focus outline appearance
    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    f97386a View commit details
    Browse the repository at this point in the history

  6. [misc] replace unnecessary calc() in center offset 

    - with `mathWithUnits`
    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    529ce7e View commit details
    Browse the repository at this point in the history

  7. Update snapshots

    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    2a43949 View commit details
    Browse the repository at this point in the history

  8. Update downstream (mostly datagrid) tests

    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    7722854 View commit details
    Browse the repository at this point in the history

  9. changelog

    @cee-chen
    cee-chen committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    66650a7 View commit details
    Browse the repository at this point in the history