Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCollapsibleNavBeta] Remove ability for accordion/group titles to contain links #7337

Merged
merged 14 commits into from
Nov 10, 2023

Commits on Nov 5, 2023

  1. [types only] cleanup in preparation for accordion href change

    - split out shared props, into main `Item` props - easier to follow combined at point as the `items` array prop
    
    - have the accordion, group, and link components use `Pick` instead of `Omit` (see above about divergence)
    
    NOTE: I played around with an ExclusiveUnion but I find the TS errors too annoying to understand how to fix - I'd rather degrade gracefully than annoy devs with hard to debug TS errors
    cee-chen committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    2f7ffdd View commit details
    Browse the repository at this point in the history
  2. Update EuiCollapsibleNavAccordion to not render links in the title

    - the whole accordion trigger should now toggle the accordion - no separate links
    cee-chen committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    f244a66 View commit details
    Browse the repository at this point in the history
  3. Update EuiCollapsibleNavItem to not pass link or accordion-specific…

    … props to accordion or link components
    
    + add missing test for `EuiCollapsibleNavGroup` - I forgot to write this before 😬
    cee-chen committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    b18971e View commit details
    Browse the repository at this point in the history
  4. Update EuiCollapsedNavItem to not render links in popover title

    - not an a11y concern here, but it's more consistent UX wise
    
    + add missed `isCollapsible` spread to button component
    cee-chen committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    2a2e9b9 View commit details
    Browse the repository at this point in the history
  5. [docs] Update Storybooks

    - remove `href` links from accordions
    
    - update `EuiCollapsibleNavItem edge` case story book more permutations
    cee-chen committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    e998b7a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d1839e9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    31fcf78 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    faae996 View commit details
    Browse the repository at this point in the history
  9. 🔥 [EuiCollapsibleNavItem] Use ExclusiveUnion to enforce either 'link …

    …or group/accordion' props
    
    - means that the `items` prop shouldn't be passed at all if `href` is
    cee-chen committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    0c2c6c3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    19f3b44 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    882611b View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    fa15cec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14a1726 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99e58fb View commit details
    Browse the repository at this point in the history