-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiCollapsibleNavBeta] Remove ability for accordion/group titles to contain links #7337
Commits on Nov 5, 2023
-
[types only] cleanup in preparation for accordion
href
change- split out shared props, into main `Item` props - easier to follow combined at point as the `items` array prop - have the accordion, group, and link components use `Pick` instead of `Omit` (see above about divergence) NOTE: I played around with an ExclusiveUnion but I find the TS errors too annoying to understand how to fix - I'd rather degrade gracefully than annoy devs with hard to debug TS errors
Configuration menu - View commit details
-
Copy full SHA for 2f7ffdd - Browse repository at this point
Copy the full SHA 2f7ffddView commit details -
Update
EuiCollapsibleNavAccordion
to not render links in the title- the whole accordion trigger should now toggle the accordion - no separate links
Configuration menu - View commit details
-
Copy full SHA for f244a66 - Browse repository at this point
Copy the full SHA f244a66View commit details -
Update
EuiCollapsibleNavItem
to not pass link or accordion-specific…… props to accordion or link components + add missing test for `EuiCollapsibleNavGroup` - I forgot to write this before 😬
Configuration menu - View commit details
-
Copy full SHA for b18971e - Browse repository at this point
Copy the full SHA b18971eView commit details -
Update
EuiCollapsedNavItem
to not render links in popover title- not an a11y concern here, but it's more consistent UX wise + add missed `isCollapsible` spread to button component
Configuration menu - View commit details
-
Copy full SHA for 2a2e9b9 - Browse repository at this point
Copy the full SHA 2a2e9b9View commit details -
- remove `href` links from accordions - update `EuiCollapsibleNavItem edge` case story book more permutations
Configuration menu - View commit details
-
Copy full SHA for e998b7a - Browse repository at this point
Copy the full SHA e998b7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1839e9 - Browse repository at this point
Copy the full SHA d1839e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31fcf78 - Browse repository at this point
Copy the full SHA 31fcf78View commit details -
Configuration menu - View commit details
-
Copy full SHA for faae996 - Browse repository at this point
Copy the full SHA faae996View commit details -
🔥 [EuiCollapsibleNavItem] Use ExclusiveUnion to enforce either 'link …
…or group/accordion' props - means that the `items` prop shouldn't be passed at all if `href` is
Configuration menu - View commit details
-
Copy full SHA for 0c2c6c3 - Browse repository at this point
Copy the full SHA 0c2c6c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19f3b44 - Browse repository at this point
Copy the full SHA 19f3b44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 882611b - Browse repository at this point
Copy the full SHA 882611bView commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fa15cec - Browse repository at this point
Copy the full SHA fa15cecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14a1726 - Browse repository at this point
Copy the full SHA 14a1726View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99e58fb - Browse repository at this point
Copy the full SHA 99e58fbView commit details