Make switch use a random id if none is provided #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
force-pushed
the
accessibility/switch
branch
from
d29c9a8
to
543bc3c
Compare
snide
force-pushed
the
accessibility/switch
branch
from
db5a1d4
to
4d650b2
Compare
| @@ -7,7 +7,7 @@ import { EuiSwitch } from './switch'; | |||
| describe('EuiSwitch', () => { | |||
| test('is rendered', () => { | |||
| const component = render( | |||
| <EuiSwitch {...requiredProps} /> | |||
| <EuiSwitch id="test" {...requiredProps} /> | |||
There was a problem hiding this comment.
Alternatively, you can mock the makeId function; having two tests, one where you pass id and one where id is generated, would provide the best coverage of the component's id logic.
chandlerprall
approved these changes
May 5, 2018
|
This PR shows really, that someone should look into the whole |
cjcenizal
approved these changes
Jul 19, 2018
snide
force-pushed
the
accessibility/switch
branch
from
4d650b2
to
3541d13
Compare
|
Updated / rebased. I'll make an issue to update the test to be more intense, but merge this for now since it's been hanging for awhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #748
Fixes #1027
Switches now generate a random id if none are passed (similar to how we do it in
EuiFormRow. This should only happen when used on their own, since most other situations will usually generate one.This seemed like the best solution since I could not require ids to be provided, otherwise it would spit out errors when
EuiFormRowcloned ids down.