Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook] Add stories for more components (leftovers) #7797

Merged
merged 10 commits into from
Jun 4, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented May 29, 2024

Summary

This PR adds component stories for a couple of components that were not covered by the tasks of #7405 yet.

This PR adds stories and VRT reference imagesfor the following components:

  • EuiBasicTable
  • EuiDatePickerRange
  • EuiSuperDatePicker
  • EuiSuperUpdateButton
  • EuiAutoRefresh
  • EuiAutoRefreshButton
  • EuiRefreshInterval

ℹ️ ❓ Currently there are also no stories for subcomponents of EuiComboBox but those components also don't seem to be used standalone and might not make much sense to be used standalone anyway. We might want to not add stories for them.

  • EuiComboBoxInput
  • EuiComboBoxOption
  • EuiComboBoxOptionsList
  • EuiComboBoxPill
  • EuiComboBoxTitle

QA

@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels May 29, 2024
@mgadewoll mgadewoll marked this pull request as ready for review May 29, 2024 13:37
@mgadewoll mgadewoll requested a review from a team as a code owner May 29, 2024 13:37
@tkajtoch tkajtoch self-requested a review May 29, 2024 16:16
@tkajtoch
Copy link
Member

That's a solid PR! Code looks great, I found a few tiny things that we could improve. Let me know what you think!

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll requested a review from tkajtoch June 4, 2024 07:35
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for answering my questions and fixing bugs! LGTM 🚢

@mgadewoll mgadewoll merged commit ed62e63 into elastic:main Jun 4, 2024
5 checks passed
@mgadewoll mgadewoll deleted the storybook/add-missing-stories branch June 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants