Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refreshMinInterval for use in EuiQuickSelectPopover #7905

Merged
merged 4 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/7905.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed `EuiSuperDatePicker` not correctly passing `refreshMinInterval` from the quick select popover
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import {
ApplyTime,
QuickSelect,
QuickSelectPanel,
Milliseconds,
} from '../../types';

export type CustomQuickSelectRenderOptions = {
Expand All @@ -57,7 +58,8 @@ export interface EuiQuickSelectPopoverProps {
isDisabled: boolean;
isPaused: boolean;
recentlyUsedRanges: DurationRange[];
refreshInterval: number;
refreshInterval: Milliseconds;
refreshMinInterval?: Milliseconds;
intervalUnits?: RefreshUnitsOptions;
start: string;
timeOptions: TimeOptions;
Expand Down Expand Up @@ -137,6 +139,7 @@ export const EuiQuickSelectPanels: FunctionComponent<
customQuickSelectRender,
isPaused,
refreshInterval,
refreshMinInterval,
intervalUnits,
applyRefreshInterval,
applyTime,
Expand Down Expand Up @@ -173,6 +176,7 @@ export const EuiQuickSelectPanels: FunctionComponent<
onRefreshChange={applyRefreshInterval}
isPaused={isPaused}
refreshInterval={refreshInterval}
minInterval={refreshMinInterval}
intervalUnits={intervalUnits}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,7 @@ export class EuiSuperDatePickerInternal extends Component<
onRefreshChange,
recentlyUsedRanges,
refreshInterval,
refreshMinInterval,
refreshIntervalUnits,
isPaused,
isDisabled,
Expand All @@ -477,6 +478,7 @@ export class EuiSuperDatePickerInternal extends Component<
isPaused={isPaused}
recentlyUsedRanges={recentlyUsedRanges}
refreshInterval={refreshInterval}
refreshMinInterval={refreshMinInterval}
intervalUnits={refreshIntervalUnits}
start={start}
timeOptions={timeOptions}
Expand Down
Loading