Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiSelectable #7940

Merged
merged 10 commits into from
Aug 5, 2024
Merged

[Emotion] Convert EuiSelectable #7940

merged 10 commits into from
Aug 5, 2024

Commits on Aug 2, 2024

  1. [tests] Convert Enzyme to RTL 

    - might as well get it out of the way now, because Enzyme snapshots will make the Emotion conversion annoying
    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    fe21d67 View commit details
    Browse the repository at this point in the history

  2. Convert base EuiSelectable styles to Emotion 

    - hooray for no theme tokens needed
    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0307e63 View commit details
    Browse the repository at this point in the history

  3. Delete unused EuiSelectableSearch Sass file 

    + add `shouldRenderCustomStyles` test
    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3249606 View commit details
    Browse the repository at this point in the history

  4. Convert EuiSelectableMessage styles

    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8a2c48f View commit details
    Browse the repository at this point in the history

  5. [setup] Create new RenderWithEuiStylesMemoizer to mirror `RenderWit… 

    …hEuiTheme`

- `EuiSelectableList` is going to need this because it's a class component with a generic :T
    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e6d0a09 View commit details
    Browse the repository at this point in the history

  6. Convert EuiSelectableList styles

    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    02a61ab View commit details
    Browse the repository at this point in the history

  7. Convert EuiSelectableListItem styles 

    + leftover __groupLabel element

+ fix `euiFontSize(s)` which has reduced line height in Emotion - not sure what the intent was here but just going to preserve the old line height for now

+ replace `.euiSelectableListItem__tooltipAnchor` with a CSS utility className

+ delete Sass variables

opinionated changes:
- change disabled text to use disabled text color specifically, not medium shade
- change item border to use the border color specifically (but transparentized to match prev lightness) instead of a random shade
    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    34a7abc View commit details
    Browse the repository at this point in the history

  8. Delete Sass files

    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f06ca5b View commit details
    Browse the repository at this point in the history

  9. Update EuiSelectable stories to contain a search example + bordered e… 

    …xample
    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b600680 View commit details
    Browse the repository at this point in the history

  10. changelog

    @cee-chen
    cee-chen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    75f7964 View commit details
    Browse the repository at this point in the history