-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiFormRow #7968
Commits on Aug 15, 2024
-
[tech debt] Convert EuiFormRow from a class to a function component
+ update unnecessary onFocus/onBlur child behavior - these events already bubble in React, so we just need to set them on a wrapper instead of cloning the children directly
Configuration menu - View commit details
-
Copy full SHA for 296d1c3 - Browse repository at this point
Copy the full SHA 296d1c3View commit details -
[tests tech debt] Convert Enzyme to RTL + update behavior tests to ac…
…count for focus changes
Configuration menu - View commit details
-
Copy full SHA for 9323d7f - Browse repository at this point
Copy the full SHA 9323d7fView commit details
Commits on Aug 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6e20d9a - Browse repository at this point
Copy the full SHA 6e20d9aView commit details -
Convert basic differentiated styles between row and column layout
+ convert margins to flex gap instead
Configuration menu - View commit details
-
Copy full SHA for a91903a - Browse repository at this point
Copy the full SHA a91903aView commit details -
Convert remaining row vs column styles
- switch width to flex-basis so we don't need to use logical property - simplify line-height, it's more centered without the 1px - remove unnecessary display block unset and margin-bottom (nothing to unset)
Configuration menu - View commit details
-
Copy full SHA for d726757 - Browse repository at this point
Copy the full SHA d726757View commit details -
Convert
center
display styling- honestly not sure why this prop is even here but oh well! - use fancy JS getters since we're no longer setting `row` as the default CSS
Configuration menu - View commit details
-
Copy full SHA for be845c5 - Browse repository at this point
Copy the full SHA be845c5View commit details -
Convert column switch-specific CSS
- use CSS `:has` instead of a separate display prop (deprecate eventually) - simplify margin logic, I found the existing CSS harder to follow than - remove unnecessary duplicated CSS (width/min-width), simplify line-height
Configuration menu - View commit details
-
Copy full SHA for 019b3d1 - Browse repository at this point
Copy the full SHA 019b3d1View commit details -
Update docs to mark
rowCompressed
andcolumCompressedSwitch
displ……ay props as deprecated + remove them from docs examples
Configuration menu - View commit details
-
Copy full SHA for 9f95c6e - Browse repository at this point
Copy the full SHA 9f95c6eView commit details -
Convert
hasEmptyLabelSpace
styles- replace margin with an EuiSpacer instead, so we can take advantage of the new gap CSS instead of having to add up to get 20px - use some trickery to duplicate existing `center` CSS (since this is essentially what the min-height/justify-content does - except doing it this way will allow it to work for column layouts as well) - remove padding-bottom, not doing anything - delete `.euiFormRow__fieldWrapperDisplayOnly` className while here, no usages in Kibana
Configuration menu - View commit details
-
Copy full SHA for 5a7f84a - Browse repository at this point
Copy the full SHA 5a7f84aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8b64fa - Browse repository at this point
Copy the full SHA f8b64faView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfa9f10 - Browse repository at this point
Copy the full SHA dfa9f10View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0cb928 - Browse repository at this point
Copy the full SHA b0cb928View commit details
Commits on Aug 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f2bb478 - Browse repository at this point
Copy the full SHA f2bb478View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58f3255 - Browse repository at this point
Copy the full SHA 58f3255View commit details -
- wasn't introduced in this PR but in the previous EuiFormLayout one - might as well fix it while we're here
Configuration menu - View commit details
-
Copy full SHA for 82c1ca8 - Browse repository at this point
Copy the full SHA 82c1ca8View commit details