Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Various row height fixes #8025

Merged
merged 11 commits into from
Sep 19, 2024
Merged

[EuiDataGrid] Various row height fixes #8025

merged 11 commits into from
Sep 19, 2024

Commits on Sep 17, 2024

  1. [storybook] Update default EuiDataGrid args to more closely mimic pro… 

    …duction usages

- including complex children such as checkboxes & badges
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e63fb84 View commit details
    Browse the repository at this point in the history

  2. Add VRT regression test for bug

    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5ad3ee5 View commit details
    Browse the repository at this point in the history

  3. Fix bug by using the undefined/default height type for lineCount: 1

    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    41d4f77 View commit details
    Browse the repository at this point in the history

  4. [cleanup] Remove now-unnecessary EuiDataGridHeaderCells button unset 

    - content is no longer inside a button, so text align is no longer needed and makes CSS overrides a little easier
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    12964b2 View commit details
    Browse the repository at this point in the history

  5. [7897] Fix control column/checkbox vertical alignment when going from… 

    … single to multi row lines
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    735c537 View commit details
    Browse the repository at this point in the history

  6. [storybook] fix custom row heights story + crashes 

    - we're only rendering 5 rows so index 5 wasn't doing anything / applying to any row. this also clearly reveals a bug with lineCount: 2

- `onChange` needs to be reset to undefined because of `enableFunctionToggleControls`+`controls.include`
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    12dec35 View commit details
    Browse the repository at this point in the history

  7. Fix bug with custom row heights lineCount 

    😭 not sure what past-me 3 years ago was smoking, but the `excludePadding` prop is no longer needed
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a08b0f9 View commit details
    Browse the repository at this point in the history

  8. [7811] Fix row heights not changing on gridStyle or `rowHeightsOpti… 

    …ons.lineHeight` change

- requires waterfalling `gridStyles` down to EuiDataGridCell
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0b9ef8a View commit details
    Browse the repository at this point in the history

  9. Fix stale cellPadding updates/calculations 

    - remove the cached styles and just use `window.getComputedStyles` - which causes a reflow, but since we need it for lineHeight in any case we might as well keep using it 🤷
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fdde820 View commit details
    Browse the repository at this point in the history

  10. changelog

    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4ccf3a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. [PR feedback] Fix rowHeights overrides not triggering a recalculation

    @cee-chen
    cee-chen committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1f35ef5 View commit details
    Browse the repository at this point in the history