Beta badges on panels #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@cchaos Sorry, had a git screwup. Addressed feedback, fixed my copy/pasta and rewrote the mixin to be more specific. Will now also size appropriately against the different panel paddings. |
cchaos
approved these changes
May 30, 2018
| // Specific | ||
| @each $modifier, $amount in $euiPanelPaddingModifiers { | ||
| .euiPanel.euiPanel--#{$modifier} { | ||
| padding: $amount; | ||
|
|
||
| // Overwrite @hasBetaBadge max-width depending upon padding |
There was a problem hiding this comment.
Should we just make all the width stuff it's own mixin? I can possibly see instances where we may not even want it to have a min-width, so it might be nice to leave it as an option.
There was a problem hiding this comment.
I'm gonna leave this as is for the moment. It's the only usage so making another mixin feels like overkill (for now). If we start using it more we probably should, but for now the @each was there anyway, so it's pretty simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #884
Feature request of @nreese.
EuiCardto a more generic mixin, then imported into cards.EuiPanel