More sliders #932
Merged
More sliders #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chandlerprall I'm not sure if that last commit made it any more readable. If you have ideas, please feel free to make edits directly. |
|
@chandlerprall Can I please get final looks on this? |
chandlerprall
approved these changes
Jul 2, 2018
added 19 commits
July 2, 2018 13:39
padding is off
Something is a little funky in IE when refreshing
This reverts commit 2cfbb8a. # Conflicts: # src/components/form/range/__snapshots__/range.test.js.snap # src/components/form/range/range.js
takes up more of the full width and aligns better
This was referenced Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fleshes out the
EuiRangecontrol to align with some requests for more options around styling.Some permutations created in the docs:
I would like a pair on this if anyone is available. It's a combo of JS and CSS/design heavy stuff.
This will be able to go in on its own, but in order to address some more custom labeled versions, I'll pass that on to @chandlerprall. But all the styles needed for that have been created in this.