Add SetExplicitRadixPoint config to json.Visitor #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
force-pushed
the
unambiguous-float
branch
2 times, most recently
from
c23d2ce
to
5fd9f62
Compare
carsonip
force-pushed
the
unambiguous-float
branch
from
5fd9f62
to
ad45eb9
Compare
SetUnambiguousFloat configures how the visitor encodes floating point values to a json float unambiguously. By default, equiv to SetUnambiguousFloat(false), the visitor will encode with the smallest number of digits. e.g. 1.0 to 1 instead of 1.0, 100000000 to 1e+8 instead of 1.0e+8. If true is passed, floating point values will always contain a decimal point, in either decimal form or scientific notation.
carsonip
force-pushed
the
unambiguous-float
branch
from
def82ec
to
ffd0e24
Compare
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
carsonip
commented
Aug 21, 2024
leehinman
reviewed
Aug 21, 2024
carsonip
changed the title
mauri870
approved these changes
Aug 22, 2024
|
@mauri870 @leehinman I don't have the merge button. Please merge and release as you see fit. |
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Aug 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/elastic/go-structform](https://togithub.com/elastic/go-structform) | `v0.0.11` -> `v0.0.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>elastic/go-structform (github.com/elastic/go-structform)</summary> ### [`v0.0.12`](https://togithub.com/elastic/go-structform/releases/tag/v0.0.12) [Compare Source](https://togithub.com/elastic/go-structform/compare/v0.0.11...v0.0.12) ##### What's Changed - Add SetExplicitRadixPoint config to json.Visitor by [@​carsonip](https://togithub.com/carsonip) in [https://github.com/elastic/go-structform/pull/48](https://togithub.com/elastic/go-structform/pull/48) ##### New Contributors - [@​carsonip](https://togithub.com/carsonip) made their first contribution in [https://github.com/elastic/go-structform/pull/48](https://togithub.com/elastic/go-structform/pull/48) **Full Changelog**: elastic/go-structform@v0.0.11...v0.0.12 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Yang Song <[email protected]>
f7o
referenced
this pull request
in f7o/opentelemetry-collector-contrib
Sep 12, 2024
](https://renovatebot.com){kind=link}
…etry#34857) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/elastic/go-structform](https://togithub.com/elastic/go-structform) | `v0.0.11` -> `v0.0.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>elastic/go-structform (github.com/elastic/go-structform)</summary> ### [`v0.0.12`](https://togithub.com/elastic/go-structform/releases/tag/v0.0.12) [Compare Source](https://togithub.com/elastic/go-structform/compare/v0.0.11...v0.0.12) ##### What's Changed - Add SetExplicitRadixPoint config to json.Visitor by [@&open-telemetry#8203;carsonip](https://togithub.com/carsonip) in [https://github.com/elastic/go-structform/pull/48](https://togithub.com/elastic/go-structform/pull/48) ##### New Contributors - [@&open-telemetry#8203;carsonip](https://togithub.com/carsonip) made their first contribution in [https://github.com/elastic/go-structform/pull/48](https://togithub.com/elastic/go-structform/pull/48) **Full Changelog**: elastic/go-structform@v0.0.11...v0.0.12 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetExplicitRadixPoint configures whether the visitor encodes floating point values with an explicit radix point.
By default, equiv to SetExplicitRadixPoint(false), the radix point will be skipped if it is not needed.
e.g. 1.0 to 1 instead of 1.0, 100000000 to 1e+8 instead of 1.0e+8.
If true is passed, the encoded number will always contain a radix point,
in either decimal form or scientific notation.
This may be useful to signal the type of the number to a json parser.
Related issue: open-telemetry/opentelemetry-collector-contrib#34680