Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use errors.Join #217

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Use errors.Join #217

merged 3 commits into from
Apr 5, 2024

Conversation

andrewkroh
Copy link
Member

Replace usages of github.com/joeshaw/multierror with errors.Join, which was added to the stdlib in Go 1.20.

Closes #216

Replace usages of github.com/joeshaw/multierror with errors.Join,
which was added to the stdlib in Go 1.20.

Closes elastic#216
@andrewkroh andrewkroh marked this pull request as ready for review April 5, 2024 03:04
efd6
efd6 previously approved these changes Apr 5, 2024
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but LGTM

providers/linux/os.go Show resolved Hide resolved
@andrewkroh
Copy link
Member Author

Apparently this repo has a setting to clear approvals if there are new commits.

@andrewkroh andrewkroh enabled auto-merge (squash) April 5, 2024 04:56
@andrewkroh andrewkroh merged commit 8885924 into elastic:main Apr 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace github.com/joeshaw/multierror with errors.Join
2 participants