This repository has been archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] use bash for readiness script #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit set the readiness probe to use bash instead of sh. This is required for Elasticsearch > 7.16.0 because the Docker image is now based on Ubuntu instead of CentOS 8, and sh on Ubuntu isn't compatible with the `if [[ ... -eq .... ]]` statements used in the readiness probe.
|
The tests aren't expected to work because the Elasticsearch chart on the main branch is still broken due to #1443. However, this should be backported to |
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 9, 2021
This commit set the readiness probe to use bash instead of sh. This is required for Elasticsearch > 7.16.0 because the Docker image is now based on Ubuntu instead of CentOS 8, and sh on Ubuntu isn't compatible with the `if [[ ... -eq .... ]]` statements used in the readiness probe.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 9, 2021
This commit update the way goss binary is retrieved in the tests/examples. The goss binary is now downloaded locally then copied inside the pod. This is needed because the Elasticsearch Ubuntu based Docker images is missing the ca-certificates package, and so the curl https command is failling with `curl: (77) error setting certificate verify locations` error. Follow-up of elastic#1458 Relates to elastic#1459 (comment)
jmlrt
added a commit
that referenced
this pull request
Dec 9, 2021
This commit update the way goss binary is retrieved in the tests/examples. The goss binary is now downloaded locally then copied inside the pod. This is needed because the Elasticsearch Ubuntu based Docker images is missing the ca-certificates package, and so the curl https command is failling with `curl: (77) error setting certificate verify locations` error. Follow-up of #1458 Relates to #1459 (comment)
jmlrt
added a commit
that referenced
this pull request
Dec 9, 2021
This commit set the readiness probe to use bash instead of sh. This is required for Elasticsearch > 7.16.0 because the Docker image is now based on Ubuntu instead of CentOS 8, and sh on Ubuntu isn't compatible with the `if [[ ... -eq .... ]]` statements used in the readiness probe.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 9, 2021
This commit update the way goss binary is retrieved in the tests/examples. The goss binary is now downloaded locally then copied inside the pod. This is needed because the Elasticsearch Ubuntu based Docker images is missing the ca-certificates package, and so the curl https command is failling with `curl: (77) error setting certificate verify locations` error. Follow-up of elastic#1458 Relates to elastic#1459 (comment)
jmlrt
added a commit
that referenced
this pull request
Dec 13, 2021
This commit update the way goss binary is retrieved in the tests/examples. The goss binary is now downloaded locally then copied inside the pod. This is needed because the Elasticsearch Ubuntu based Docker images is missing the ca-certificates package, and so the curl https command is failling with `curl: (77) error setting certificate verify locations` error. Follow-up of #1458 Relates to #1459 (comment)
This was referenced Dec 13, 2021
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit set the readiness probe to use bash instead of sh. This is
required for Elasticsearch > 7.16.0 because the Docker image is now
based on Ubuntu instead of CentOS 8, and sh on Ubuntu isn't compatible
with the
if [[ ... -eq .... ]]statements used in the readiness probe.cc @elastic/es-delivery