Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[metricbeat] remove es metricset search query for oss example #1469

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Dec 13, 2021

This commit removes the goss test in charge of querying Elasticsearch
search API for container metricset in Metricbeat oss example.

This is because the default Elasticsearch used in this test is also used
by the default Metricbeat and so the search API usually return indices
for default Metricbeat for this query in the test environment.

This commit removes the goss test in charge of querying Elasticsearch
search API for container metricset in Metricbeat oss example.

This is because the default Elasticsearch used in this test is also used
by the default Metricbeat and so the search API usually return indices
for default Metricbeat for this query in the test environment.
Copy link
Member

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@framsouza framsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt merged commit fdaba22 into elastic:main Dec 13, 2021
@jmlrt jmlrt deleted the fix-mb-oss branch December 13, 2021 15:21
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 13, 2021
…c#1469)

This commit removes the goss test in charge of querying Elasticsearch
search API for container metricset in Metricbeat oss example.

This is because the default Elasticsearch used in this test is also used
by the default Metricbeat and so the search API usually return indices
for default Metricbeat for this query in the test environment.
jmlrt added a commit that referenced this pull request Dec 13, 2021
…#1470)

This commit removes the goss test in charge of querying Elasticsearch
search API for container metricset in Metricbeat oss example.

This is because the default Elasticsearch used in this test is also used
by the default Metricbeat and so the search API usually return indices
for default Metricbeat for this query in the test environment.
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants