Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] SSL by default #1519

Merged
merged 49 commits into from
Feb 8, 2022
Merged

Conversation

framsouza
Copy link
Contributor

Fix #1443

This PR add ssl configuration by default in our helm chart. The SSL certs are generated by helm.

elasticsearch/values.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements to do but this is really good 👍🏻

elasticsearch/templates/secret-cert.yaml Outdated Show resolved Hide resolved
@jmlrt
Copy link
Member

jmlrt commented Dec 22, 2021

Also https://github.com/elastic/helm-charts/tree/main/elasticsearch#how-to-deploy-clusters-with-security-authentication-and-tls-enabled should be updated to mention that certs are created by default but you can provide your own certs using the example in https://github.com/elastic/helm-charts/tree/main/elasticsearch/examples/security

elasticsearch/values.yaml Outdated Show resolved Hide resolved
@framsouza framsouza requested a review from jmlrt January 5, 2022 11:22
@jmlrt
Copy link
Member

jmlrt commented Jan 5, 2022

jenkins test this please

elasticsearch/templates/statefulset.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+integration-elasticsearch/1250/ES_SUITE=multi,KUBERNETES_VERSION=1.19,label=docker&&virtual/console is failing because the data and client Helm releases are creating their own secret cert instead of mounting the one created by the master release.

I think that data and client values for this test should be updated with:

createCert: false
secretMounts:
  - name: elastic-certificates
    secretName: multi-master-certs
    path: /usr/share/elasticsearch/config/certs

apm-server/examples/default/test/goss.yaml Outdated Show resolved Hide resolved
@framsouza framsouza requested a review from jmlrt January 6, 2022 09:06
@framsouza
Copy link
Contributor Author

checking

logstash/examples/default/test/goss.yaml Outdated Show resolved Hide resolved
apm-server/examples/default/test/goss.yaml Outdated Show resolved Hide resolved
apm-server/examples/upgrade/test/goss.yaml Outdated Show resolved Hide resolved
logstash/examples/default/test/goss.yaml Outdated Show resolved Hide resolved
logstash/examples/elasticsearch/test/goss.yaml Outdated Show resolved Hide resolved
logstash/examples/security/test/goss.yaml Outdated Show resolved Hide resolved
logstash/examples/upgrade/test/goss.yaml Outdated Show resolved Hide resolved
logstash/examples/upgrade/test/goss.yaml Outdated Show resolved Hide resolved
elasticsearch/examples/multi/data.yaml Show resolved Hide resolved
elasticsearch/examples/multi/client.yaml Show resolved Hide resolved
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Member

jmlrt commented Feb 8, 2022

Elasticsearch tests are successful 🎉
Thank you @framsouza for your work on this PR 👍🏻

As discussed, we'll merge this PR and fix the tests for the other charts in dedicated follow-up PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[elasticsearch] Readiness probe is failing again with 8.0.0-SNAPSHOT and default config
3 participants