Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] fix escaping issue in readinessprobe (#625) #626

Closed
wants to merge 2 commits into from

Conversation

denysvitali
Copy link

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented May 17, 2020

💚 CLA has been signed

@denysvitali
Copy link
Author

CLA signed, but the CLA bot doesn't seem to mark it as signed. Let's wait...

@denysvitali
Copy link
Author

Nevermind, this implementation needs to be double checked: it fails if the username/password is not set 🤔

@fatmcgav
Copy link
Contributor

@denysvitali Cheers for taking the time to open the issue and this PR.

I think your implementation is pretty much there.
However I've been doing some refactoring of the readinessProbe in-order to resolve #631, which should also solve this issue.
Feel free to test the changes in #638 and let me know if they work for you.

@denysvitali
Copy link
Author

Thanks @fatmcgav !
I'll make sure to check your changes, thanks for fixing the issue!

@fatmcgav
Copy link
Contributor

Superseded by #638

@fatmcgav fatmcgav closed this May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants