[filebeat] variable maxUnavailable updateStrategy #809
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
cla signed |
|
jenkins test this please |
|
cla signed |
|
cla/check |
|
LGTM⛴ |
jmlrt
changed the title
|
jenkins test this please |
There was a problem hiding this comment.
Oops, MaxUnavailable value is still missing in the README value table. Can you add it please?
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist. |
|
@clemcvlcs, I merged master on your branch and updated it in regard of #964 which is adding Filebeat deployment, also updated README and tests. I can't push on your branch so my changes are 2ce2c79, 873fd83 and 7029852. Are you interested to update your PR with these changes so we can merge it? |
|
jenkins test this please |
|
Ooops forgot to format python tests https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+lint-python/784/label=docker&&virtual&&ubuntu-18.04/console 🤦 Can you run The other error (https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+template-testing/1163/CHART=filebeat,label=docker&&virtual/console) is strange and I don't have it locally. I'll rerun the CI tests after formatting. |
|
jenkins test this please |
jmlrt
changed the title
Problem
Unable to set a custom value for the
MaxUnavalaiblefor therollingUpdatefilebeat's update strategy.This option should be available especially for filbert, because there is no need to have a MaxUnavailable set to 1 when there's one filebeat pod per node.
What I've done in PR
Add an
{{- if }}statement to theupdateStrategyregarding theMaxUnavaillablevariable. If the variable is not set, the default value is et to 1 (current value set right now).Chart version
filebeat 7.9.1
Tools versions
Helm version
Client: {Version:"v3.3.0", GitCommit:"8a4aeec08d67a7b84472007529e8097ec3742105", GitTreeState:"dirty", GoVersion:"go1.14.6"}
kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:12:48Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"darwin/amd64"}