Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests using journalctl tool to start a custom independent agent #11186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Sep 19, 2024

Proposed commit message

Avoid using Elastic Agent complete image for tests requiring the usage of journalctl tool. As the goal is to replace those complete images to the corresponding wolfi images, those wolfi images would not have that tool available.

Those tests will be running on Elastic Agent images based on docker.elastic.co/elastic-agent/elastic-agent. systemd package will be installed in order to be available journalctl tool for the tests requiring it customizing the independent Elastic Agents used.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • [ ] I have verified that all data streams collect metrics or logs.
  • [ ] I have added an entry to my package's changelog.yml file.
  • [ ] I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Related issues

@mrodm mrodm self-assigned this Sep 19, 2024
@andrewkroh andrewkroh added Integration:iptables Iptables Integration:journald Custom Journald logs labels Sep 19, 2024
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

language: "sh"
contents: |
set -eu
if grep fedora /etc/os-release > /dev/null ; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support in case the base image is an UBI image (e.g. docker.elastic.co/elastic-agent/elastic-agent-ubi).

@mrodm mrodm force-pushed the update-packages-using-journalctl branch from a1e1c0e to 468f504 Compare September 19, 2024 15:47
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm requested a review from a team September 20, 2024 14:57
@mrodm mrodm marked this pull request as ready for review September 20, 2024 15:21
@mrodm mrodm requested review from a team as code owners September 20, 2024 15:21
@andrewkroh andrewkroh added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Sep 20, 2024
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:iptables Iptables Integration:journald Custom Journald logs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants