Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netflow]: Append all ip addresses found to the related.ip field. #11193

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aleksmaus
Copy link
Member

Proposed commit message

Append all ip addresses found to the related.ip field.

I was not sure if the original issue meant specific fields, if yes then ipv6 was not included in the list.

Anyways, in the first cut appending all the fields that end with *_ipv4_address or *_ipv6_address.
Can redo if the list of the fields limited to just: netflow.post_nat_destination_ipv4_address , netflow.post_nat_source_ipv4_address, netflow.post_nat_destination_ipv6_address , netflow.post_nat_source_ipv6_address.

Let me know.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@aleksmaus aleksmaus added enhancement New feature or request Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Sep 19, 2024
@aleksmaus aleksmaus self-assigned this Sep 19, 2024
@aleksmaus aleksmaus requested a review from a team as a code owner September 19, 2024 21:21
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@andrewkroh andrewkroh added the Integration:netflow NetFlow Records label Sep 19, 2024
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @aleksmaus

@aleksmaus aleksmaus requested a review from a team September 19, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:netflow NetFlow Records Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetFlow Records Integration: Append Network Address Translation IP fields to related.ip
3 participants