Copy ingest-pipeline to ingest_pipeline #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, both exist. As soon as Kibana is updated, the old one can be removed. This PR is only in draft yet, as it also requires the registry to be updated to elastic/package-registry#581 first.
|
PR updated as elastic/package-registry#581 was merged. |
mtojek
approved these changes
Jul 2, 2020
|
I think we need to inform @jonathan-buttner about such changes. |
|
@mtojek Thanks for the reminder. Yes @jonathan-buttner you also need to update your repo. |
💚 Build Succeeded
Expand to view the summary
Build stats
|
mtojek
reviewed
Jul 2, 2020
|
|
||
| func main() { | ||
| // Find all directories with ingest-pipeline | ||
| ingestPipelineDirs, _ := filepath.Glob("./*/dataset/*/elasticsearch/ingest-pi*") |
There was a problem hiding this comment.
@ruflin just noticed this file: I don't think it should be versioned. Is that on purpose?
There was a problem hiding this comment.
@mtojek No, I forgot to remove it. I also need to take it out on the storage. On the storage layer I thought to keep it in for when I remove the old directories and then directly remove it. We could do the same here or remove it directly.
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
For now, both exist. As soon as Kibana is updated, the old one can be removed. This PR is only in draft yet, as it also requires the registry to be updated to elastic/package-registry#581 first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, both exist. As soon as Kibana is updated, the old one can be removed.