Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kibana] Add memory utilization metric #8617

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

pgayvallet
Copy link
Contributor

Adds mappings for new Kibana memory fields added in elastic/kibana#172146 to the monitoring templates.

Corresponding Beats PR: elastic/beats#37232

@pgayvallet pgayvallet added Integration:kibana Kibana Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Nov 30, 2023
@pgayvallet pgayvallet self-assigned this Nov 30, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-30T15:02:51.365+0000

  • Duration: 35 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 1
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (4/4) 💚 5.556
Classes 100.0% (4/4) 💚 5.556
Methods 95.556% (43/45) 👍 5.855
Lines 87.234% (82/94) 👍 1.151
Conditionals 100.0% (0/0) 💚

@pgayvallet pgayvallet marked this pull request as ready for review November 30, 2023 14:23
@pgayvallet pgayvallet requested a review from a team as a code owner November 30, 2023 14:23
Comment on lines +99 to +104
},
"array_buffers": {
"bytes": 2197869632
},
"external": {
"bytes": 4890295460
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to also add the cgroup fields to this sample as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 1400f29

@pgayvallet pgayvallet merged commit 9130537 into elastic:main Nov 30, 2023
4 checks passed
@elasticmachine
Copy link

Package kibana - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=kibana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:kibana Kibana Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants