-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tenable IO] Add request tracing to vulnerability datastream and capture chain requests #8831
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
asset |
1326.26 | 855.43 | -470.83 (-35.5%) | 💔 |
To see the full report comment with /test benchmark fullreport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will you put up another PR after the beats issue is merged?
Yes, I will come up with a PR after. |
Package tenable_io - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=tenable_io |
1 similar comment
Package tenable_io - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=tenable_io |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Proposed commit message
vulnerability
datastream.NOTE: This PR hardcodes the tracer filenames instead of using the default filename
"../../logs/httpjson/http-request-trace-*.ndjson"
. This is because of the non-sanitisation of chain request tracer filenames explained in elastic/beats#37551Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
elastic-package stack down && elastic-package build && elastic-package stack up --version=8.11.3 -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test system --generate -v