Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_ftd]: escape hyphen inside regex char list #9569

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

Proposed commit message

After tackling this issue, a respective PR was created to elastic-package to mainstream the detection of similar warnings. Thus this PR fixes the following similar to the former issue regex-related warning for cisco_ftd

character class has '-' without escape

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

Related issues

N/A

Screenshots

N/A

@pkoutsovasilis pkoutsovasilis force-pushed the pkoutsovasilis/fix_cisco_ftd_regex_warnings branch from cb3615d to 83eb55e Compare April 11, 2024 10:20
@pkoutsovasilis pkoutsovasilis added bug Something isn't working, use only for issues Integration:cisco_ftd Cisco FTD Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Apr 11, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Apr 11, 2024
@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review April 11, 2024 10:21
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner April 11, 2024 10:21
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

elasticmachine commented Apr 11, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@dwhyrock
Copy link
Contributor

Data stream Previous EPS New EPS Diff (%) Result
log 800.64 165.02 -635.62 (-79.39%) 💔

Do we need to be concerned about the performance report?

@pkoutsovasilis
Copy link
Contributor Author

Data stream Previous EPS New EPS Diff (%) Result
log 800.64 165.02 -635.62 (-79.39%) 💔
Do we need to be concerned about the performance report?

hmmm not sure to be honest I just escaped a hyphen I didn't expect such a massive impact on perf 🤷‍♂️

@pkoutsovasilis
Copy link
Contributor Author

/test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @pkoutsovasilis

Copy link

@pkoutsovasilis pkoutsovasilis merged commit e511395 into main Apr 15, 2024
5 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/fix_cisco_ftd_regex_warnings branch April 15, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cisco_ftd Cisco FTD Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants