Fix stale value in editor shortcut command (#48484) (#48531)

elastic · Oct 17, 2019 · 0a6a456 · 0a6a456
1 parent b78273a
commit 0a6a456
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...ns/console/np_ready/public/application/containers/editor/legacy/console_editor/editor.tsx b/...ns/console/np_ready/public/application/containers/editor/legacy/console_editor/editor.tsx
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import React, { CSSProperties, useEffect, useRef, useState } from 'react';
+import React, { CSSProperties, useCallback, useEffect, useRef, useState } from 'react';
 import { EuiToolTip } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
@@ -143,7 +143,7 @@ function _Editor({ previousStateLocation = 'stored' }: EditorProps) {
     };
   }, []);
 
-  const sendCurrentRequestToES = () => {
+  const sendCurrentRequestToES = useCallback(() => {
     dispatch({
       type: 'sendRequestToEs',
       value: {
@@ -153,7 +153,7 @@ function _Editor({ previousStateLocation = 'stored' }: EditorProps) {
           history.addToHistory(esPath, esMethod, esData),
       },
     });
-  };
+  }, [settings]);
 
   useEffect(() => {
     applyCurrentSettings(editorInstanceRef.current!, settings);
@@ -167,7 +167,7 @@ function _Editor({ previousStateLocation = 'stored' }: EditorProps) {
       sendCurrentRequestToES,
       openDocumentation,
     });
-  }, []);
+  }, [sendCurrentRequestToES]);
 
   return (
     <div style={abs} className="conApp">

diff --git a/...np_ready/public/application/containers/editor/legacy/console_editor/keyboard_shortcuts.ts b/...np_ready/public/application/containers/editor/legacy/console_editor/keyboard_shortcuts.ts
@@ -18,7 +18,7 @@
  */
 
 interface Actions {
-  input: any;
+  input: any; // TODO: Wrap this in an editor interface
   sendCurrentRequestToES: () => void;
   openDocumentation: () => void;
 }