Skip to content

Commit

Permalink
Clean up last Sidebar with temp copy placement
Browse files Browse the repository at this point in the history
This is so that CI will pass and we can get this merged in and do the actual wiring up of everything in a separate PR.
  • Loading branch information
scottybollinger committed Nov 20, 2020
1 parent 6335dfb commit 0d8940a
Showing 1 changed file with 9 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
SOURCE_SCHEMAS_PATH,
SOURCE_DISPLAY_SETTINGS_PATH,
SOURCE_SETTINGS_PATH,
SOURCES_PATH,
getContentSourcePath as sourcePath,
getSourcesPath,
} from '../../routes';
Expand All @@ -49,11 +48,6 @@ export const SourceRouter: React.FC = () => {
const { contentSource, dataLoading } = useValues(SourceLogic);
const { isOrganization } = useValues(AppLogic);

const breadcrumbs = {
topLevelPath: getSourcesPath(SOURCES_PATH, isOrganization),
topLevelName: '← All content sources',
};

useEffect(() => {
initializeSource(sourceId, history);
}, []);
Expand Down Expand Up @@ -102,29 +96,20 @@ export const SourceRouter: React.FC = () => {
sidebarLinks = [overviewLink, contentLink, sourceSettingsLink];
}

/** TODO: Replace this in Kibana
const sidebar = (
<SidebarNavigation
title={
<span className="eui-textOverflowWrap" title={name}>
{name}
</span>
}
titleCssClass="content-source-title"
breadcrumbs={breadcrumbs}
headerChildren={
const pageHeader = (
<div>
<span className="eui-textOverflowWrap" title={name}>
{name}

<SourceInfoCard
sourceName={serviceName}
sourceType={serviceType}
dateCreated={moment(createdAt).format('MMMM D, YYYY')}
isFederatedSource={isFederatedSource}
/>
}
links={sidebarLinks}
isFederatedSource={isFederatedSource}
/>
</span>
</div>
);
*/

const callout = (
<>
Expand All @@ -144,6 +129,8 @@ export const SourceRouter: React.FC = () => {
return (
<>
{!supportedByLicense && callout}
{/* TODO: Figure out with design how to make this look better */}
{pageHeader}
<Switch>
<Route
exact
Expand Down

0 comments on commit 0d8940a

Please sign in to comment.