fix skipped test test/accessibility/apps/dashboard·ts - Dashboard cre…

…ate dashboard button #111233 (#112872) * test if 2s sleep fixes flakey test * switch from sleep to retry.waitFor * remove .only, add comments to config file about sample data add/remove Co-authored-by: Kibana Machine <[email protected]>
elastic · Sep 28, 2021 · 200d035 · 200d035
1 parent 3dcfd44
commit 200d035
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/test/accessibility/apps/dashboard.ts b/test/accessibility/apps/dashboard.ts
@@ -15,7 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
   const listingTable = getService('listingTable');
 
-  describe.skip('Dashboard', () => {
+  describe('Dashboard', () => {
     const dashboardName = 'Dashboard Listing A11y';
     const clonedDashboardName = 'Dashboard Listing A11y Copy';
 

diff --git a/test/accessibility/config.ts b/test/accessibility/config.ts
@@ -17,15 +17,19 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
     ...functionalConfig.getAll(),
 
     testFiles: [
-      require.resolve('./apps/discover'),
+      // these 5 tests all load addSampleDataSet('flights')
+      // only the last test does removeSampleDataSet('flights')
       require.resolve('./apps/dashboard'),
       require.resolve('./apps/dashboard_panel'),
+      require.resolve('./apps/filter_panel'),
+      require.resolve('./apps/home'),
+      require.resolve('./apps/kibana_overview'),
+
+      // next tests don't use sample data
+      require.resolve('./apps/discover'),
       require.resolve('./apps/visualize'),
       require.resolve('./apps/management'),
       require.resolve('./apps/console'),
-      require.resolve('./apps/home'),
-      require.resolve('./apps/filter_panel'),
-      require.resolve('./apps/kibana_overview'),
     ],
     pageObjects,
     services,

diff --git a/test/functional/page_objects/home_page.ts b/test/functional/page_objects/home_page.ts
@@ -45,8 +45,11 @@ export class HomePageObject extends FtrService {
   async addSampleDataSet(id: string) {
     const isInstalled = await this.isSampleDataSetInstalled(id);
     if (!isInstalled) {
-      await this.testSubjects.click(`addSampleDataSet${id}`);
-      await this._waitForSampleDataLoadingAction(id);
+      await this.retry.waitFor('wait until sample data is installed', async () => {
+        await this.testSubjects.click(`addSampleDataSet${id}`);
+        await this._waitForSampleDataLoadingAction(id);
+        return await this.isSampleDataSetInstalled(id);
+      });
     }
   }