Skip to content

Commit

Permalink
Removed one liner deprecation found with ElasticClient and made it ha…
Browse files Browse the repository at this point in the history
…rder to accidently import from the kbn package (#110318) (#110348)

## Summary

Removes ElasticSearch deprecation and makes it harder to import it from the wrong package. I accidentally exposed a deprecated `ElasticSearch` from a package we do not want to expose and everyone's IDE is suggesting it rather than the correct one from Kibana core.

* Removes the type from the exports within the package
* Fixes the instance that is trying to import it in favor of the correct one.

Co-authored-by: Frank Hassanabad <[email protected]>
  • Loading branch information
kibanamachine and FrankHassanabad authored Aug 26, 2021
1 parent fa310c2 commit 2fc96d9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 0 additions & 1 deletion packages/kbn-securitysolution-es-utils/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export * from './decode_version';
export * from './delete_all_index';
export * from './delete_policy';
export * from './delete_template';
export * from './elasticsearch_client';
export * from './encode_hit_version';
export * from './get_index_aliases';
export * from './get_index_count';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,17 @@ import type { ListArray, ExceptionListItemSchema } from '@kbn/securitysolution-i
import { MAX_EXCEPTION_LIST_SIZE } from '@kbn/securitysolution-list-constants';
import { hasLargeValueList } from '@kbn/securitysolution-list-utils';
import { parseScheduleDates } from '@kbn/securitysolution-io-ts-utils';
import { ElasticsearchClient } from '@kbn/securitysolution-es-utils';

import {
TimestampOverrideOrUndefined,
Privilege,
RuleExecutionStatus,
} from '../../../../common/detection_engine/schemas/common/schemas';
import { Logger, SavedObjectsClientContract } from '../../../../../../../src/core/server';
import {
ElasticsearchClient,
Logger,
SavedObjectsClientContract,
} from '../../../../../../../src/core/server';
import {
AlertInstanceContext,
AlertInstanceState,
Expand Down

0 comments on commit 2fc96d9

Please sign in to comment.