Skip to content

Commit

Permalink
[APM] Increase xpack.apm.ui.transactionGroupBucketSize (#71661) (#7…
Browse files Browse the repository at this point in the history
…2431)

Co-authored-by: Søren Louv-Jansen <[email protected]>
  • Loading branch information
cauemarcondes and sorenlouv authored Jul 20, 2020
1 parent ad99cbd commit 40da9e6
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion docs/settings/apm-settings.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Changing these settings may disable features of the APM App.
| Set to `false` to hide the APM app from the menu. Defaults to `true`.

| `xpack.apm.ui.transactionGroupBucketSize`
| Number of top transaction groups displayed in the APM app. Defaults to `100`.
| Number of top transaction groups displayed in the APM app. Defaults to `1000`.

| `xpack.apm.ui.maxTraceItems` {ess-icon}
| Maximum number of child items displayed when viewing trace details. Defaults to `1000`.
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const config = {
autocreateApmIndexPattern: schema.boolean({ defaultValue: true }),
ui: schema.object({
enabled: schema.boolean({ defaultValue: true }),
transactionGroupBucketSize: schema.number({ defaultValue: 100 }),
transactionGroupBucketSize: schema.number({ defaultValue: 1000 }),
maxTraceItems: schema.number({ defaultValue: 1000 }),
}),
telemetryCollectionEnabled: schema.boolean({ defaultValue: true }),
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion x-pack/plugins/apm/server/lib/transaction_groups/fetcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ export async function transactionGroupsFetcher(
aggs: {
transaction_groups: {
composite: {
size: bucketSize + 1, // 1 extra bucket is added to check whether the total number of buckets exceed the specified bucket size.
// traces overview is hardcoded to 10000
// transactions overview: 1 extra bucket is added to check whether the total number of buckets exceed the specified bucket size.
size: isTopTraces ? 10000 : bucketSize + 1,
sources: [
...(isTopTraces
? [{ service: { terms: { field: SERVICE_NAME } } }]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
);

expect(response.status).to.be(200);
expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 100 });
expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 1000 });
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
);

expect(response.status).to.be(200);
expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 100 });
expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 1000 });
});
});

Expand Down

0 comments on commit 40da9e6

Please sign in to comment.