[Lens] Fix error when selecting the current field again (#84817)

elastic · Dec 3, 2020 · 47917b3 · 47917b3
1 parent 61fdec2
commit 47917b3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.test.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.test.tsx
@@ -1229,6 +1229,24 @@ describe('IndexPatternDimensionEditorPanel', () => {
     );
   });
 
+  it('should not update when selecting the current field again', () => {
+    wrapper = mount(<IndexPatternDimensionEditorComponent {...defaultProps} />);
+
+    const comboBox = wrapper
+      .find(EuiComboBox)
+      .filter('[data-test-subj="indexPattern-dimension-field"]');
+
+    const option = comboBox
+      .prop('options')![1]
+      .options!.find(({ label }) => label === 'timestampLabel')!;
+
+    act(() => {
+      comboBox.prop('onChange')!([option]);
+    });
+
+    expect(setState).not.toHaveBeenCalled();
+  });
+
   it('should show all operations that are not filtered out', () => {
     wrapper = mount(
       <IndexPatternDimensionEditorComponent

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/field_select.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/field_select.tsx
@@ -195,9 +195,12 @@ export function FieldSelect({
           return;
         }
 
-        trackUiEvent('indexpattern_dimension_field_changed');
+        const choice = (choices[0].value as unknown) as FieldChoice;
 
-        onChoose((choices[0].value as unknown) as FieldChoice);
+        if (choice.field !== selectedField) {
+          trackUiEvent('indexpattern_dimension_field_changed');
+          onChoose(choice);
+        }
       }}
       renderOption={(option, searchValue) => {
         return (