address ome review comments

x-pack/plugins/global_search_providers/server/providers/saved_objects/map_object_to_result.test.ts

@@ -14,11 +14,6 @@ const createType = (props: Partial<SavedObjectsType>): SavedObjectsType => {
     namespaceType: 'single',
     mappings: { properties: {} },
     ...props,
-    management: {
-      defaultSearchField: 'field',
-      getInAppUrl: (obj) => ({ path: `/object/${obj.id}`, uiCapabilitiesPath: '' }),
-      ...props.management,
-    },
   };
 };
 
@@ -65,6 +60,53 @@ describe('mapToResult', () => {
       score: 42,
     });
   });
+
+  it('throws if the type do not have management information', () => {
+    const object = createObject(
+      { id: 'dash1', type: 'dashboard', score: 42 },
+      { title: 'My dashboard' }
+    );
+
+    expect(() => {
+      mapToResult(
+        object,
+        createType({
+          name: 'dashboard',
+          management: {
+            getInAppUrl: (obj) => ({ path: `/dashboard/${obj.id}`, uiCapabilitiesPath: '' }),
+          },
+        })
+      );
+    }).toThrowErrorMatchingInlineSnapshot(
+      `"Trying to map an object from a type without management metadata"`
+    );
+
+    expect(() => {
+      mapToResult(
+        object,
+        createType({
+          name: 'dashboard',
+          management: {
+            defaultSearchField: 'title',
+          },
+        })
+      );
+    }).toThrowErrorMatchingInlineSnapshot(
+      `"Trying to map an object from a type without management metadata"`
+    );
+
+    expect(() => {
+      mapToResult(
+        object,
+        createType({
+          name: 'dashboard',
+          management: undefined,
+        })
+      );
+    }).toThrowErrorMatchingInlineSnapshot(
+      `"Trying to map an object from a type without management metadata"`
+    );
+  });
 });
 
 describe('mapToResults', () => {

x-pack/plugins/global_search_providers/server/providers/saved_objects/map_object_to_result.ts

@@ -22,13 +22,17 @@ export const mapToResult = (
   object: SavedObjectsFindResult<unknown>,
   type: SavedObjectsType
 ): GlobalSearchProviderResult => {
-  const { defaultSearchField, getInAppUrl } = type.management!;
-
+  const { defaultSearchField, getInAppUrl } = type.management ?? {};
+  if (defaultSearchField === undefined || getInAppUrl === undefined) {
+    throw new Error('Trying to map an object from a type without management metadata');
+  }
   return {
     id: object.id,
-    title: (object.attributes as any)[defaultSearchField!],
+    // defaultSearchField is dynamic and not 'directly' bound to the generic type of the SavedObject
+    // so we are forced to cast the attributes to any to access the properties associated with it.
+    title: (object.attributes as any)[defaultSearchField],
     type: object.type,
-    url: getInAppUrl!(object).path,
+    url: getInAppUrl(object).path,
     score: object.score,
   };
 };

x-pack/plugins/global_search_providers/server/providers/saved_objects/provider.ts

@@ -19,9 +19,9 @@ export const createSavedObjectsResultProvider = (): GlobalSearchResultProvider =
         .getAllTypes()
         .filter((type) => !typeRegistry.isHidden(type.name))
         .filter((type) => type.management?.defaultSearchField && type.management?.getInAppUrl);
-      const searchFields = [
-        ...new Set(searchableTypes.map((type) => type.management!.defaultSearchField!)),
-      ];
+      const searchFields = uniq(
+        searchableTypes.map((type) => type.management!.defaultSearchField!)
+      );
 
       const responsePromise = client.find({
         page: 1,
@@ -39,3 +39,5 @@ export const createSavedObjectsResultProvider = (): GlobalSearchResultProvider =
     },
   };
 };
+
+const uniq = <T>(values: T[]): T[] => [...new Set(values)];