[ML] SWIM_LANE_DEFAULT_PAGE_SIZE

elastic · Jul 1, 2020 · 57e4cae · 57e4cae
1 parent 69c5a44
commit 57e4cae
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/x-pack/plugins/ml/public/application/explorer/explorer_constants.ts b/x-pack/plugins/ml/public/application/explorer/explorer_constants.ts
@@ -67,3 +67,8 @@ export const VIEW_BY_JOB_LABEL = i18n.translate('xpack.ml.explorer.jobIdLabel',
  * aggregations on influencers values.
  */
 export const ANOMALY_SWIM_LANE_HARD_LIMIT = 1000;
+
+/**
+ * Default page size fot the anomaly swim lane.
+ */
+export const SWIM_LANE_DEFAULT_PAGE_SIZE = 10;
diff --git a/x-pack/plugins/ml/public/application/explorer/reducers/explorer_reducer/state.ts b/x-pack/plugins/ml/public/application/explorer/reducers/explorer_reducer/state.ts
@@ -21,6 +21,7 @@ import {
   SwimlaneData,
   ViewBySwimLaneData,
 } from '../../explorer_utils';
+import { SWIM_LANE_DEFAULT_PAGE_SIZE } from '../../explorer_constants';
 
 export interface ExplorerState {
   annotationsData: any[];
@@ -94,7 +95,7 @@ export function getExplorerDefaultState(): ExplorerState {
     viewBySwimlaneDataLoading: false,
     viewBySwimlaneFieldName: undefined,
     viewBySwimlaneOptions: [],
-    viewByPerPage: 10,
+    viewByPerPage: SWIM_LANE_DEFAULT_PAGE_SIZE,
     viewByFromPage: 1,
     swimlaneLimit: undefined,
   };

diff --git a/x-pack/plugins/ml/public/application/services/results_service/results_service.js b/x-pack/plugins/ml/public/application/services/results_service/results_service.js
@@ -590,7 +590,7 @@ export function resultsServiceProvider(mlApiServices) {
                 influencerFieldValues: {
                   terms: {
                     field: 'influencer_field_value',
-                    size: maxResults || 1,
+                    size: !!maxResults ? maxResults : ANOMALY_SWIM_LANE_HARD_LIMIT,
                     order: {
                       maxAnomalyScore: 'desc',
                     },

diff --git a/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/swimlane_input_resolver.ts b/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/swimlane_input_resolver.ts
@@ -28,6 +28,7 @@ import {
 import { MlStartDependencies } from '../../plugin';
 import {
   ANOMALY_SWIM_LANE_HARD_LIMIT,
+  SWIM_LANE_DEFAULT_PAGE_SIZE,
   SWIMLANE_TYPE,
   SwimlaneType,
 } from '../../application/explorer/explorer_constants';
@@ -53,8 +54,6 @@ function getJobsObservable(
   );
 }
 
-export const EMBEDDABLE_DEFAULT_PER_PAGE = 10;
-
 export function useSwimlaneInputResolver(
   embeddableInput: Observable<AnomalySwimlaneEmbeddableInput>,
   onInputChange: (output: Partial<AnomalySwimlaneEmbeddableOutput>) => void,
@@ -102,7 +101,7 @@ export function useSwimlaneInputResolver(
         startWith(undefined),
         // no need to emit when the initial value has been set
         distinctUntilChanged(
-          (prev, curr) => prev === undefined && curr === EMBEDDABLE_DEFAULT_PER_PAGE
+          (prev, curr) => prev === undefined && curr === SWIM_LANE_DEFAULT_PAGE_SIZE
         )
       ),
       refresh.pipe(startWith(null)),
@@ -154,7 +153,7 @@ export function useSwimlaneInputResolver(
               if (overallSwimlaneData && swimlaneTypeInput === SWIMLANE_TYPE.VIEW_BY) {
                 if (perPageFromState === undefined) {
                   // set initial pagination from the input or default one
-                  setPerPage(perPageInput ?? EMBEDDABLE_DEFAULT_PER_PAGE);
+                  setPerPage(perPageInput ?? SWIM_LANE_DEFAULT_PAGE_SIZE);
                 }
 
                 if (viewMode === ViewMode.EDIT && perPageFromState !== perPageInput) {
@@ -171,7 +170,7 @@ export function useSwimlaneInputResolver(
                     isViewBySwimLaneData(swimlaneData)
                       ? swimlaneData.cardinality
                       : ANOMALY_SWIM_LANE_HARD_LIMIT,
-                    perPageFromState ?? perPageInput ?? EMBEDDABLE_DEFAULT_PER_PAGE,
+                    perPageFromState ?? perPageInput ?? SWIM_LANE_DEFAULT_PAGE_SIZE,
                     fromPageInput,
                     swimlaneContainerWidth,
                     appliedFilters
@@ -224,7 +223,7 @@ export function useSwimlaneInputResolver(
   return [
     swimlaneType,
     swimlaneData,
-    perPage ?? EMBEDDABLE_DEFAULT_PER_PAGE,
+    perPage ?? SWIM_LANE_DEFAULT_PAGE_SIZE,
     setPerPage,
     timeBuckets,
     isLoading,