Skip to content

Commit

Permalink
rename testSubj for consitency
Browse files Browse the repository at this point in the history
  • Loading branch information
alvarezmelissa87 committed Aug 5, 2020
1 parent e602eb4 commit 58d750b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export const EditButtonFlyout: FC<Required<EditAction>> = ({ closeFlyout, item }
onClose={closeFlyout}
hideCloseButton
aria-labelledby="analyticsEditFlyoutTitle"
data-test-subj="analyticsEditFlyout"
data-test-subj="mlAnalyticsEditFlyout"
>
<EuiFlyoutHeader hasBorder>
<EuiTitle size="m">
Expand Down Expand Up @@ -297,7 +297,7 @@ export const EditButtonFlyout: FC<Required<EditAction>> = ({ closeFlyout, item }
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButton
data-test-subj="analyticsEditFlyoutUpdateButton"
data-test-subj="mlAnalyticsEditFlyoutUpdateButton"
onClick={onSubmit}
fill
isDisabled={updateButtonDisabled}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ export function MachineLearningDataFrameAnalyticsEditProvider(
},

async assertAnalyticsEditFlyoutMissing() {
await testSubjects.missingOrFail('analyticsEditFlyoutUpdateButton');
await testSubjects.missingOrFail('mlAnalyticsEditFlyout');
},

async updateAnalyticsJob() {
await testSubjects.existOrFail('analyticsEditFlyoutUpdateButton');
await testSubjects.click('analyticsEditFlyoutUpdateButton');
await testSubjects.existOrFail('mlAnalyticsEditFlyoutUpdateButton');
await testSubjects.click('mlAnalyticsEditFlyoutUpdateButton');
await retry.tryForTime(5000, async () => {
await this.assertAnalyticsEditFlyoutMissing();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function MachineLearningDataFrameAnalyticsTableProvider({ getService }: F
public async openEditFlyout(analyticsId: string) {
await this.openRowActions(analyticsId);
await testSubjects.click('mlAnalyticsJobEditButton');
await testSubjects.existOrFail('analyticsEditFlyout', { timeout: 5000 });
await testSubjects.existOrFail('mlAnalyticsEditFlyout', { timeout: 5000 });
}

async assertAnalyticsSearchInputValue(expectedSearchValue: string) {
Expand Down

0 comments on commit 58d750b

Please sign in to comment.