[ML] Functional tests - stabilize slider value selection (#94313) (#9…

…4399) This PR stabilizes the slider value selection during ML functional tests. Co-authored-by: Robert Oskamp <[email protected]>
elastic · Mar 11, 2021 · 5ea70ea · 5ea70ea
1 parent 0d0ccbf
commit 5ea70ea
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/x-pack/test/functional/services/ml/common_ui.ts b/x-pack/test/functional/services/ml/common_ui.ts
@@ -167,10 +167,10 @@ export function MachineLearningCommonUIProvider({ getService }: FtrProviderConte
     async setSliderValue(testDataSubj: string, value: number) {
       const slider = await testSubjects.find(testDataSubj);
 
-      let currentValue = await slider.getAttribute('value');
-      let currentDiff = +currentValue - +value;
-
       await retry.tryForTime(60 * 1000, async () => {
+        const currentValue = await slider.getAttribute('value');
+        const currentDiff = +currentValue - +value;
+
         if (currentDiff === 0) {
           return true;
         } else {
@@ -189,20 +189,13 @@ export function MachineLearningCommonUIProvider({ getService }: FtrProviderConte
           }
           await retry.tryForTime(1000, async () => {
             const newValue = await slider.getAttribute('value');
-            if (newValue !== currentValue) {
-              currentValue = newValue;
-              currentDiff = +currentValue - +value;
-              return true;
-            } else {
+            if (newValue === currentValue) {
               throw new Error(`slider value should have changed, but is still ${currentValue}`);
             }
           });
-
-          throw new Error(`slider value should be '${value}' (got '${currentValue}')`);
+          await this.assertSliderValue(testDataSubj, value);
         }
       });
-
-      await this.assertSliderValue(testDataSubj, value);
     },
 
     async assertSliderValue(testDataSubj: string, expectedValue: number) {