fix typescript error. clarify comment

elastic · Oct 18, 2019 · 695aaed · 695aaed
1 parent 4a788f2
commit 695aaed
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/x-pack/legacy/plugins/ml/public/data_frame_analytics/common/analytics.ts b/x-pack/legacy/plugins/ml/public/data_frame_analytics/common/analytics.ts
@@ -83,7 +83,7 @@ export const getDependentVar = (analysis: AnalysisConfig) => {
 };
 
 export const getPredictionFieldName = (analysis: AnalysisConfig) => {
-  // Default to dependent_variable
+  // If undefined will be defaulted to dependent_variable when config is created
   let predictionFieldName;
   if (isRegressionAnalysis(analysis) && analysis.regression.prediction_field_name !== undefined) {
     predictionFieldName = analysis.regression.prediction_field_name;
@@ -214,9 +214,7 @@ export const loadEvalData = async ({
     predictionFieldName ? predictionFieldName : defaultPredictionField
   }`;
 
-  const query = { term: {} };
-  // @ts-ignore TODO: fix types here
-  query.term[`${resultsField}.is_training`] = { value: isTraining };
+  const query = { term: { [`${resultsField}.is_training`]: { value: isTraining } } };
 
   const config = {
     index,