Skip to content

Commit

Permalink
fix conflict (#51147)
Browse files Browse the repository at this point in the history
  • Loading branch information
flash1293 authored and Liza Katz committed Nov 20, 2019
1 parent 9cb37a1 commit 74fb377
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/kibana/public/dashboard/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ async function getAngularDependencies(): Promise<LegacyAngularInjectedDependenci
(async () => {
const instance = new DashboardPlugin();
instance.setup(npSetup.core, {
feature_catalogue: npSetup.plugins.feature_catalogue,
...npSetup.plugins,
__LEGACY: {
localApplicationService,
getAngularDependencies,
Expand Down
10 changes: 5 additions & 5 deletions src/legacy/core_plugins/kibana/public/dashboard/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ import { NavigationStart } from '../../../navigation/public';
import { DashboardConstants } from './dashboard_constants';
import {
FeatureCatalogueCategory,
FeatureCatalogueSetup,
} from '../../../../../plugins/feature_catalogue/public';
HomePublicPluginSetup,
} from '../../../../../plugins/home/public';
import { SharePluginStart } from '../../../../../plugins/share/public';

export interface LegacyAngularInjectedDependencies {
Expand All @@ -59,7 +59,7 @@ export interface DashboardPluginSetupDependencies {
getAngularDependencies: () => Promise<LegacyAngularInjectedDependencies>;
localApplicationService: LocalApplicationService;
};
feature_catalogue: FeatureCatalogueSetup;
home: HomePublicPluginSetup;
}

export class DashboardPlugin implements Plugin {
Expand All @@ -76,7 +76,7 @@ export class DashboardPlugin implements Plugin {
core: CoreSetup,
{
__LEGACY: { localApplicationService, getAngularDependencies, ...legacyServices },
feature_catalogue,
home,
}: DashboardPluginSetupDependencies
) {
const app: App = {
Expand Down Expand Up @@ -120,7 +120,7 @@ export class DashboardPlugin implements Plugin {
localApplicationService.register({ ...app, id: 'dashboard' });
localApplicationService.register({ ...app, id: 'dashboards' });

feature_catalogue.register({
home.featureCatalogue.register({
id: 'dashboard',
title: i18n.translate('kbn.dashboard.featureCatalogue.dashboardTitle', {
defaultMessage: 'Dashboard',
Expand Down

0 comments on commit 74fb377

Please sign in to comment.