Migrate savedObjectManagementActionRegistry to NP plugin (#60481)

* create empty plugin + move home feature registration to it

* move the so action_registry to new plugin

* adapt existing calls to the registry

* fix i18n namespace

* fix table unit tests

* update codeowners

* rename plugin to match other PRs

* remove registerLegacyAPI from spaces public plugin

* fix typo

Co-authored-by: Elastic Machine <[email protected]>

.i18nrc.json

@@ -33,6 +33,7 @@
     "newsfeed": "src/plugins/newsfeed",
     "regionMap": "src/legacy/core_plugins/region_map",
     "savedObjects": "src/plugins/saved_objects",
+    "savedObjectsManagement": "src/plugins/saved_objects_management",
     "server": "src/legacy/server",
     "statusPage": "src/legacy/core_plugins/status_page",
     "telemetry": [

src/legacy/core_plugins/kibana/public/management/sections/objects/components/objects_table/components/table/__jest__/table.test.js

@@ -21,17 +21,16 @@ import React from 'react';
 import { shallowWithI18nProvider, mountWithI18nProvider } from 'test_utils/enzyme_helpers';
 import { findTestSubject } from '@elastic/eui/lib/test';
 import { keyCodes } from '@elastic/eui/lib/services';
-import { mockManagementPlugin } from '../../../../../../../../../../management/public/np_ready/mocks';
+import { npSetup as mockNpSetup } from '../../../../../../../../../../../ui/public/new_platform/__mocks__';
 
 jest.mock('ui/kfetch', () => ({ kfetch: jest.fn() }));
 
 jest.mock('ui/chrome', () => ({
   addBasePath: () => '',
 }));
 
-jest.mock('../../../../../../../../../../management/public/legacy', () => ({
-  setup: mockManagementPlugin.createSetupContract(),
-  start: mockManagementPlugin.createStartContract(),
+jest.mock('ui/new_platform', () => ({
+  npSetup: mockNpSetup,
 }));
 
 import { Table } from '../table';

src/legacy/core_plugins/kibana/public/management/sections/objects/components/objects_table/components/table/table.js

@@ -18,7 +18,7 @@
  */
 
 import chrome from 'ui/chrome';
-import { setup as managementSetup } from '../../../../../../../../../management/public/legacy';
+import { npSetup } from 'ui/new_platform';
 import React, { PureComponent, Fragment } from 'react';
 import PropTypes from 'prop-types';
 
@@ -79,7 +79,7 @@ export class Table extends PureComponent {
 
   constructor(props) {
     super(props);
-    this.extraActions = managementSetup.savedObjects.registry.get();
+    this.extraActions = npSetup.plugins.savedObjectsManagement.actionRegistry.getAll();
   }
 
   onChange = ({ query, error }) => {

src/legacy/core_plugins/management/public/index.ts

@@ -30,8 +30,6 @@ export {
   plugin,
   IndexPatternCreationConfig,
   IndexPatternListConfig,
-  SavedObjectsManagementAction,
-  SavedObjectsManagementRecord,
 } from './np_ready';
 
 export {

src/legacy/core_plugins/management/public/np_ready/index.ts

@@ -40,8 +40,3 @@ export {
   IndexPatternCreationConfig,
   IndexPatternListConfig,
 } from './services/index_pattern_management';
-
-export {
-  SavedObjectsManagementAction,
-  SavedObjectsManagementRecord,
-} from './services/saved_objects_management';

src/legacy/core_plugins/management/public/np_ready/mocks.ts

@@ -40,13 +40,6 @@ const createSetupContract = (): ManagementSetup => ({
       areScriptedFieldsEnabled: jest.fn(),
     } as any,
   },
-  savedObjects: {
-    registry: {
-      register: jest.fn(),
-      has: jest.fn(),
-      get: jest.fn(() => []),
-    },
-  },
 });
 
 const createStartContract = (): ManagementStart => ({});

src/legacy/core_plugins/management/public/np_ready/plugin.ts

@@ -19,10 +19,6 @@
 import { PluginInitializerContext, CoreSetup, CoreStart, Plugin } from 'src/core/public';
 import { HomePublicPluginSetup } from 'src/plugins/home/public';
 import { IndexPatternManagementService, IndexPatternManagementSetup } from './services';
-import {
-  SavedObjectsManagementService,
-  SavedObjectsManagementServiceSetup,
-} from './services/saved_objects_management';
 
 export interface ManagementPluginSetupDependencies {
   home: HomePublicPluginSetup;
@@ -33,7 +29,6 @@ interface ManagementPluginStartDependencies {}
 
 export interface ManagementSetup {
   indexPattern: IndexPatternManagementSetup;
-  savedObjects: SavedObjectsManagementServiceSetup;
 }
 
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
@@ -48,14 +43,12 @@ export class ManagementPlugin
       ManagementPluginStartDependencies
     > {
   private readonly indexPattern = new IndexPatternManagementService();
-  private readonly savedObjects = new SavedObjectsManagementService();
 
   constructor(initializerContext: PluginInitializerContext) {}
 
   public setup(core: CoreSetup, { home }: ManagementPluginSetupDependencies) {
     return {
       indexPattern: this.indexPattern.setup({ httpClient: core.http, home }),
-      savedObjects: this.savedObjects.setup({ home }),
     };
   }
 

src/legacy/core_plugins/management/public/np_ready/services/index.ts

@@ -18,4 +18,3 @@
  */
 
 export * from './index_pattern_management';
-export * from './saved_objects_management';

src/legacy/ui/public/new_platform/__mocks__/helpers.ts

@@ -30,6 +30,7 @@ import { usageCollectionPluginMock } from '../../../../../plugins/usage_collecti
 import { kibanaLegacyPluginMock } from '../../../../../plugins/kibana_legacy/public/mocks';
 import { chartPluginMock } from '../../../../../plugins/charts/public/mocks';
 import { advancedSettingsMock } from '../../../../../plugins/advanced_settings/public/mocks';
+import { savedObjectsManagementPluginMock } from '../../../../../plugins/saved_objects_management/public/mocks';
 /* eslint-enable @kbn/eslint/no-restricted-paths */
 
 export const pluginsMock = {
@@ -44,6 +45,7 @@ export const pluginsMock = {
     usageCollection: usageCollectionPluginMock.createSetupContract(),
     advancedSettings: advancedSettingsMock.createSetupContract(),
     kibanaLegacy: kibanaLegacyPluginMock.createSetupContract(),
+    savedObjectsManagement: savedObjectsManagementPluginMock.createSetupContract(),
   }),
   createStart: () => ({
     data: dataPluginMock.createStartContract(),
@@ -56,6 +58,7 @@ export const pluginsMock = {
     management: managementPluginMock.createStartContract(),
     advancedSettings: advancedSettingsMock.createStartContract(),
     kibanaLegacy: kibanaLegacyPluginMock.createStartContract(),
+    savedObjectsManagement: savedObjectsManagementPluginMock.createStartContract(),
   }),
 };
 

src/legacy/ui/public/new_platform/new_platform.ts

@@ -67,6 +67,10 @@ import {
 } from '../../../../plugins/navigation/public';
 import { VisTypeVegaSetup } from '../../../../plugins/vis_type_vega/public';
 import { DiscoverSetup, DiscoverStart } from '../../../../plugins/discover/public';
+import {
+  SavedObjectsManagementPluginSetup,
+  SavedObjectsManagementPluginStart,
+} from '../../../../plugins/saved_objects_management/public';
 
 export interface PluginsSetup {
   bfetch: BfetchPublicSetup;
@@ -87,6 +91,7 @@ export interface PluginsSetup {
   visTypeVega: VisTypeVegaSetup;
   discover: DiscoverSetup;
   telemetry?: TelemetryPluginSetup;
+  savedObjectsManagement: SavedObjectsManagementPluginSetup;
 }
 
 export interface PluginsStart {
@@ -106,6 +111,7 @@ export interface PluginsStart {
   discover: DiscoverStart;
   telemetry?: TelemetryPluginStart;
   dashboard: DashboardStart;
+  savedObjectsManagement: SavedObjectsManagementPluginStart;
 }
 
 export const npSetup = {

src/plugins/saved_objects_management/kibana.json

@@ -2,5 +2,6 @@
   "id": "savedObjectsManagement",
   "version": "kibana",
   "server": true,
-  "ui": false
+  "ui": true,
+  "requiredPlugins": ["home"]
 }

src/plugins/saved_objects_management/public/index.ts

@@ -0,0 +1,32 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { PluginInitializerContext } from 'kibana/public';
+import { SavedObjectsManagementPlugin } from './plugin';
+
+export { SavedObjectsManagementPluginSetup, SavedObjectsManagementPluginStart } from './plugin';
+export {
+  ISavedObjectsManagementActionRegistry,
+  SavedObjectsManagementAction,
+  SavedObjectsManagementRecord,
+} from './services';
+
+export function plugin(initializerContext: PluginInitializerContext) {
+  return new SavedObjectsManagementPlugin();
+}

src/plugins/saved_objects_management/public/mocks.ts

@@ -0,0 +1,39 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { actionRegistryMock } from './services/action_registry.mock';
+import { SavedObjectsManagementPluginSetup, SavedObjectsManagementPluginStart } from './plugin';
+
+const createSetupContractMock = (): jest.Mocked<SavedObjectsManagementPluginSetup> => {
+  const mock = {
+    actionRegistry: actionRegistryMock.create(),
+  };
+  return mock;
+};
+
+const createStartContractMock = (): jest.Mocked<SavedObjectsManagementPluginStart> => {
+  const mock = {};
+  return mock;
+};
+
+export const savedObjectsManagementPluginMock = {
+  createActionRegistry: actionRegistryMock.create,
+  createSetupContract: createSetupContractMock,
+  createStartContract: createStartContractMock,
+};

src/plugins/saved_objects_management/public/plugin.test.ts

@@ -0,0 +1,47 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { coreMock } from '../../../core/public/mocks';
+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
+import { homePluginMock } from '../../home/public/mocks';
+import { SavedObjectsManagementPlugin } from './plugin';
+
+describe('SavedObjectsManagementPlugin', () => {
+  let plugin: SavedObjectsManagementPlugin;
+
+  beforeEach(() => {
+    plugin = new SavedObjectsManagementPlugin();
+  });
+
+  describe('#setup', () => {
+    it('registers the saved_objects feature to the home plugin', async () => {
+      const coreSetup = coreMock.createSetup();
+      const homeSetup = homePluginMock.createSetupContract();
+
+      await plugin.setup(coreSetup, { home: homeSetup });
+
+      expect(homeSetup.featureCatalogue.register).toHaveBeenCalledTimes(1);
+      expect(homeSetup.featureCatalogue.register).toHaveBeenCalledWith(
+        expect.objectContaining({
+          id: 'saved_objects',
+        })
+      );
+    });
+  });
+});