Skip to content

Commit

Permalink
Fix Vega react eslint errors (#54259) (#54284)
Browse files Browse the repository at this point in the history
  • Loading branch information
Tim Roes authored Jan 9, 2020
1 parent 16d375f commit 7ed0906
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
6 changes: 0 additions & 6 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,6 @@ module.exports = {
'react-hooks/exhaustive-deps': 'off',
},
},
{
files: ['src/legacy/core_plugins/vis_type_vega/**/*.{js,ts,tsx}'],
rules: {
'react-hooks/exhaustive-deps': 'off',
},
},
{
files: ['src/legacy/ui/public/vis/**/*.{js,ts,tsx}'],
rules: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ function VegaActionsMenu({ formatHJson, formatJson }: VegaActionsMenuProps) {
const onHJsonCLick = useCallback(() => {
formatHJson();
setIsPopoverOpen(false);
}, [isPopoverOpen, formatHJson]);
}, [formatHJson]);

const onJsonCLick = useCallback(() => {
formatJson();
setIsPopoverOpen(false);
}, [isPopoverOpen, formatJson]);
}, [formatJson]);

const closePopover = useCallback(() => setIsPopoverOpen(false), []);

Expand Down

0 comments on commit 7ed0906

Please sign in to comment.