Added comment to code to explain why the arrays were sorted.

elastic · Apr 30, 2020 · 8d32828 · 8d32828
1 parent ade2ece
commit 8d32828
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/x-pack/test/api_integration/apis/management/index_management/indices.js b/x-pack/test/api_integration/apis/management/index_management/indices.js
@@ -198,6 +198,8 @@ export default function({ getService }) {
           'ilm', // data enricher
           'isRollupIndex', // data enricher
         ];
+        // We need to sort the keys before comparing then, because race conditions
+        // can cause enrichers to register in non-deterministic order.
         const sortedExpectedKeys = expectedKeys.sort();
         const sortedReceivedKeys = Object.keys(body[0]).sort();
         expect(sortedReceivedKeys).to.eql(sortedExpectedKeys);
@@ -226,6 +228,8 @@ export default function({ getService }) {
             'ilm', // data enricher
             'isRollupIndex', // data enricher
           ];
+          // We need to sort the keys before comparing then, because race conditions
+          // can cause enrichers to register in non-deterministic order.
           const sortedExpectedKeys = expectedKeys.sort();
           const sortedReceivedKeys = Object.keys(body[0]).sort();
           expect(sortedReceivedKeys).to.eql(sortedExpectedKeys);